Page MenuHomeFreeBSD
Differential D18282

sfxge(4): use transceiver ID when reading info
ClosedPublic
Actions

Authored by arybchik on Nov 21 2018, 11:58 AM.
Tags
None
Referenced Files
F170745769: D18282.id.diff
Sun, Sep 6, 9:24 AM
F170693014: D18282.id51415.diff
Sun, Sep 6, 1:39 AM
F170653015: D18282.id50882.diff
Sat, Sep 5, 8:10 PM
Unknown Object (File)
Sat, Sep 5, 2:57 PM
Unknown Object (File)
Sat, Sep 5, 11:38 AM
Unknown Object (File)
Fri, Sep 4, 10:26 PM
Unknown Object (File)
Fri, Sep 4, 6:05 PM
Unknown Object (File)
Thu, Sep 3, 11:13 AM
View All Files
Subscribers
imp

Details

Reviewers
gnn
philip
Commits
rS341321: sfxge(4): use transceiver ID when reading info
Summary

In efx_mcdi_phy_module_get_info() probe the
transceiver identification byte rather than assume
the module matches the fixed port type. This
supports scenarios such as a SFP mounted in a QSFP
port via a QSA module.

Submitted by: Richard Houldsworth <rhouldsworth at solarflare.com>
Sponsored by: Solarflare Communications, Inc.

Test Plan

amd64 tinderbox kernel builds tested
driver loaded/unloaded, interfaces up/down, traffic works fine

Diff Detail

Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 21140
Build 20503: arc lint + arc unit

Event Timeline

arybchik created this revision.Nov 21 2018, 11:58 AM
Harbormaster completed remote builds in B21140: Diff 50882.Nov 21 2018, 11:58 AM
This revision was not accepted when it landed; it landed in state Needs Review.Nov 30 2018, 7:10 AM
Closed by commit rS341321: sfxge(4): use transceiver ID when reading info (authored by arybchik). · Explain Why
This revision was automatically updated to reflect the committed changes.
Herald added a subscriber: imp. · View Herald TranscriptNov 30 2018, 7:10 AM

Revision Contents
Changeset List

PathSize
sys/
dev/
sfxge/
common/
46 lines

Diff 50882

View Options

sys/dev/sfxge/common/efx_mcdi.c

Loading...