Page MenuHomeFreeBSD
Differential D18280

sfxge(4): guard Rx scale code with corresponding option
ClosedPublic
Actions

Authored by arybchik on Nov 21 2018, 11:58 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Nov 20, 9:05 PM
Unknown Object (File)
Thu, Nov 20, 9:04 PM
Unknown Object (File)
Thu, Nov 20, 9:04 PM
Unknown Object (File)
Thu, Nov 20, 8:56 PM
Unknown Object (File)
Tue, Nov 18, 10:13 AM
Unknown Object (File)
Tue, Nov 18, 9:21 AM
Unknown Object (File)
Tue, Nov 18, 4:29 AM
Unknown Object (File)
Tue, Nov 18, 1:32 AM
View All 64 Files
Subscribers
imp

Details

Reviewers
gnn
philip
Commits
rS341319: sfxge(4): guard Rx scale code with corresponding option
Summary

Previously only some of the code was guarded by this which caused
a build error when EFSYS_OPT_RX_SCALE is 0 (e.g. in manftest).

Submitted by: Tom Millington <tmillington at solarflare.com>
Sponsored by: Solarflare Communications, Inc.

Test Plan

amd64 tinderbox kernel builds tested
driver loaded/unloaded, interfaces up/down, traffic works fine

Diff Detail

Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 21138
Build 20501: arc lint + arc unit

Event Timeline

arybchik created this revision.Nov 21 2018, 11:58 AM
Harbormaster completed remote builds in B21138: Diff 50880.Nov 21 2018, 11:58 AM
This revision was not accepted when it landed; it landed in state Needs Review.Nov 30 2018, 7:09 AM
Closed by commit rS341319: sfxge(4): guard Rx scale code with corresponding option (authored by arybchik). · Explain Why
This revision was automatically updated to reflect the committed changes.
Herald added a subscriber: imp. · View Herald TranscriptNov 30 2018, 7:09 AM

Revision Contents
Changeset List

PathSize
sys/
dev/
sfxge/
common/
7 lines
2 lines
2 lines

Diff 50880

View Options

sys/dev/sfxge/common/ef10_nic.c

Loading...
View Options

sys/dev/sfxge/common/efx.h

Loading...
View Options

sys/dev/sfxge/common/siena_nic.c

Loading...