sfxge(4): simplify the code to parse RSS hash type
ClosedPublic
Actions

Authored by arybchik on Nov 21 2018, 11:56 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Thu, Aug 27, 12:43 AM

	Unknown Object (File)
	Wed, Aug 26, 8:21 AM

	Unknown Object (File)
	Tue, Aug 25, 11:31 PM

	Unknown Object (File)
	Tue, Aug 25, 10:37 PM

	Unknown Object (File)
	Tue, Aug 25, 10:37 PM

	Unknown Object (File)
	Mon, Aug 24, 11:29 PM

	Unknown Object (File)
	Sun, Aug 23, 12:16 AM

	Unknown Object (File)
	Tue, Aug 11, 11:48 PM

View All 97 Files

Subscribers

imp

Details

Reviewers

gnn
philip

Commits

rS341306: sfxge(4): simplify the code to parse RSS hash type

Summary

RSS mode bits can be accessed a lot easier in the hash
type value provided that the variable type is uint32_t.
The macro helper can be removed to enhance readability.

Submitted by: Ivan Malov <ivan.malov at oktetlabs.ru>
Sponsored by: Solarflare Communications, Inc.

Test Plan

amd64 tinderbox kernel builds tested
driver loaded/unloaded, interfaces up/down, traffic works fine

Diff Detail

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 21126
Build 20489: arc lint + arc unit

Event Timeline

arybchik created this revision.Nov 21 2018, 11:56 AM

Harbormaster completed remote builds in B21126: Diff 50867.Nov 21 2018, 11:56 AM

This revision was not accepted when it landed; it landed in state Needs Review.Nov 30 2018, 7:07 AM

Closed by commit rS341306: sfxge(4): simplify the code to parse RSS hash type (authored by arybchik). · Explain Why

This revision was automatically updated to reflect the committed changes.

Herald added a subscriber: imp. · View Herald TranscriptNov 30 2018, 7:07 AM

Revision Contents
Changeset List

Path

Size

sys/

dev/

sfxge/

common/

ef10_rx.c

24 lines

efx.h

2 lines

Diff 50867

View Options

sys/dev/sfxge/common/ef10_rx.c