sfxge(4): prevent access to the NIC config before probe
ClosedPublic
Actions

Authored by arybchik on Nov 21 2018, 11:55 AM.

Tags

None

Referenced Files

	F174551260: D18263.id50862.diff
	Sun, Oct 4, 2:49 AM

	F174542078: D18263.id51396.diff
	Sun, Oct 4, 1:24 AM

	F174540883: D18263.diff
	Sun, Oct 4, 1:11 AM

	Unknown Object (File)
	Tue, Sep 29, 7:13 PM

	Unknown Object (File)
	Tue, Sep 29, 3:20 PM

	Unknown Object (File)
	Tue, Sep 22, 10:25 PM

	Unknown Object (File)
	Tue, Sep 22, 9:43 PM

	Unknown Object (File)
	Tue, Sep 22, 9:35 PM

View All Files

Subscribers

imp

Details

Reviewers

gnn
philip

Commits

rS342517: MFC r341301
rS342446: MFC r341301
rS342338: MFC r341301
rS341301: sfxge(4): prevent access to the NIC config before probe

Summary

NIC config is initialized during NIC probe.

Submitted by: Mark Spender <mspender at solarflare.com>
Sponsored by: Solarflare Communications, Inc.
MFC after: 1 week

Test Plan

amd64 tinderbox kernel builds tested
driver loaded/unloaded, interfaces up/down, traffic works fine

Diff Detail

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 21121
Build 20484: arc lint + arc unit

Event Timeline

arybchik created this revision.Nov 21 2018, 11:55 AM

Harbormaster completed remote builds in B21121: Diff 50862.Nov 21 2018, 11:55 AM

This revision was not accepted when it landed; it landed in state Needs Review.Nov 30 2018, 7:07 AM

Closed by commit rS341301: sfxge(4): prevent access to the NIC config before probe (authored by arybchik). · Explain Why

This revision was automatically updated to reflect the committed changes.

Herald added a subscriber: imp. · View Herald TranscriptNov 30 2018, 7:07 AM

Revision Contents
Changeset List

Path

Size

sys/

dev/

sfxge/

common/

efx_nic.c

1 line

Diff 50862

View Options

sys/dev/sfxge/common/efx_nic.c

sfxge(4): prevent access to the NIC config before probeClosedPublicActions