Page MenuHomeFreeBSD
Differential D18258

sfxge(4): add information if TSO workaround is required
ClosedPublic
Actions

Authored by arybchik on Nov 21 2018, 11:54 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Dec 17, 10:51 AM
Unknown Object (File)
Tue, Dec 10, 7:10 AM
Unknown Object (File)
Sat, Nov 30, 3:27 PM
Unknown Object (File)
Sat, Nov 30, 1:58 PM
Unknown Object (File)
Nov 1 2024, 2:49 PM
Unknown Object (File)
Oct 21 2024, 6:31 PM
Unknown Object (File)
Oct 21 2024, 6:31 PM
Unknown Object (File)
Oct 21 2024, 6:31 PM
View All 38 Files
Subscribers
imp

Details

Reviewers
gnn
philip
Commits
rS341296: sfxge(4): add information if TSO workaround is required
Summary

In SF bug 61297 it's been confirmed that the hardware does not always
calculate the TCP checksum correctly with TSO sends.

The value of the Total Length field (IPv4) or Payload Length field
(IPv6) is the critical factor. We're sufficiently confident that if
these fields are zero then the checksum will be calculated correctly.

The information may be used by the drivers to check if the workaround is
required when FATSOv2 is implemented.

Submitted by: Mark Spender <mspender at solarflare.com>
Sponsored by: Solarflare Communications, Inc.

Test Plan

amd64 tinderbox kernel builds tested
driver loaded/unloaded, interfaces up/down, traffic works fine

Diff Detail

Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 21116
Build 20479: arc lint + arc unit

Event Timeline

arybchik created this revision.Nov 21 2018, 11:54 AM
Harbormaster completed remote builds in B21116: Diff 50857.Nov 21 2018, 11:54 AM
This revision was not accepted when it landed; it landed in state Needs Review.Nov 30 2018, 7:07 AM
Closed by commit rS341296: sfxge(4): add information if TSO workaround is required (authored by arybchik). · Explain Why
This revision was automatically updated to reflect the committed changes.
Herald added a subscriber: imp. · View Herald TranscriptNov 30 2018, 7:07 AM

Revision Contents
Changeset List

PathSize
sys/
dev/
sfxge/
common/
1 line
3 lines
3 lines
3 lines

Diff 50857

View Options

sys/dev/sfxge/common/efx.h

Loading...
View Options

sys/dev/sfxge/common/hunt_nic.c

Loading...
View Options

sys/dev/sfxge/common/medford2_nic.c

Loading...
View Options

sys/dev/sfxge/common/medford_nic.c

Loading...