sfxge(4): avoid usage of too big arrays on stack
ClosedPublic
Actions

Authored by arybchik on Nov 21 2018, 11:54 AM.

Tags

None

Referenced Files

	F84291269: D18257.id.diff
	Tue, May 21, 9:51 PM

	F84245732: D18257.id51390.diff
	Tue, May 21, 9:26 AM

	Unknown Object (File)
	Mon, May 6, 1:16 PM

	Unknown Object (File)
	Mon, May 6, 1:10 PM

	Unknown Object (File)
	Mon, May 6, 7:30 AM

	Unknown Object (File)
	Mon, May 6, 7:26 AM

	Unknown Object (File)
	Sun, May 5, 8:29 PM

	Unknown Object (File)
	Sun, May 5, 6:28 PM

View All 18 Files

Subscribers

imp

Details

Reviewers

gnn
philip

Commits

rS342515: MFC r341295
rS342444: MFC r341295
rS342337: MFC r341295
rS341295: sfxge(4): avoid usage of too big arrays on stack

Summary

Found by PreFAST static analysis.

Submitted by: Martin Harvey <mharvey at solarflare.com>
Sponsored by: Solarflare Communications, Inc.
MFC after: 1 week

Test Plan

amd64 tinderbox kernel builds tested
driver loaded/unloaded, interfaces up/down, traffic works fine

Diff Detail

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 21115
Build 20478: arc lint + arc unit

Event Timeline

arybchik created this revision.Nov 21 2018, 11:54 AM

Harbormaster completed remote builds in B21115: Diff 50856.Nov 21 2018, 11:54 AM

This revision was not accepted when it landed; it landed in state Needs Review.Nov 30 2018, 7:07 AM

Closed by commit rS341295: sfxge(4): avoid usage of too big arrays on stack (authored by arybchik). · Explain Why

This revision was automatically updated to reflect the committed changes.

Herald added a subscriber: imp. · View Herald TranscriptNov 30 2018, 7:07 AM

Revision Contents
Changeset List

Path

Size

sys/

dev/

sfxge/

common/

ef10_phy.c

18 lines

efx_nvram.c

27 lines

Diff 50856

View Options

sys/dev/sfxge/common/ef10_phy.c