Page MenuHomeFreeBSD
Differential D18248

sfxge(4): move empty efsys definitions to EFX headers
ClosedPublic
Actions

Authored by arybchik on Nov 21 2018, 11:52 AM.
Tags
None
Referenced Files
F138090749: D18248.id51381.diff
Fri, Nov 28, 7:50 PM
Unknown Object (File)
Thu, Nov 20, 9:46 PM
Unknown Object (File)
Thu, Nov 20, 9:45 PM
Unknown Object (File)
Thu, Nov 20, 9:45 PM
Unknown Object (File)
Thu, Nov 20, 9:37 PM
Unknown Object (File)
Tue, Nov 18, 2:32 PM
Unknown Object (File)
Tue, Nov 18, 11:16 AM
Unknown Object (File)
Tue, Nov 18, 7:07 AM
View All 76 Files
Subscribers
imp

Details

Reviewers
gnn
philip
Commits
rS341283: sfxge(4): move empty efsys definitions to EFX headers
Summary

Move empty definitions for platform-specific annotations from efsys.h
to EFX headers.

Submitted by: Martin Harvey <mharvey at solarflare.com>
Submitted by: Andrew Lee <alee at solarflare.com>
Sponsored by: Solarflare Communications, Inc.

Test Plan

amd64 tinderbox kernel builds tested
driver loaded/unloaded, interfaces up/down, traffic works fine

Diff Detail

Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 21106
Build 20469: arc lint + arc unit

Event Timeline

arybchik created this revision.Nov 21 2018, 11:52 AM
Harbormaster completed remote builds in B21106: Diff 50847.Nov 21 2018, 11:52 AM
This revision was not accepted when it landed; it landed in state Needs Review.Nov 30 2018, 5:50 AM
Closed by commit rS341283: sfxge(4): move empty efsys definitions to EFX headers (authored by arybchik). · Explain Why
This revision was automatically updated to reflect the committed changes.
Herald added a subscriber: imp. · View Herald TranscriptNov 30 2018, 5:50 AM

Revision Contents
Changeset List

PathSize
sys/
dev/
sfxge/
common/
39 lines
1 line
129 lines
modules/
sfxge/
3 lines

Diff 50847

View Options

sys/dev/sfxge/common/efsys.h

Loading...
View Options

sys/dev/sfxge/common/efx.h

Loading...
View Options

sys/dev/sfxge/common/efx_annote.h

Loading...
View Options

sys/modules/sfxge/Makefile

Loading...