Page MenuHomeFreeBSD
Differential D18234

sfxge(4): make RxQ type data an union
ClosedPublic
Actions

Authored by arybchik on Nov 21 2018, 11:49 AM.
Tags
None
Referenced Files
F151733770: D18234.diff
Fri, Apr 10, 8:16 AM
F151726249: D18234.id51331.diff
Fri, Apr 10, 7:14 AM
Unknown Object (File)
Mon, Apr 6, 2:48 PM
Unknown Object (File)
Tue, Mar 31, 5:01 PM
Unknown Object (File)
Tue, Mar 17, 6:38 PM
Unknown Object (File)
Sun, Mar 15, 2:04 PM
Unknown Object (File)
Sun, Mar 15, 9:01 AM
Unknown Object (File)
Mar 9 2026, 9:09 PM
View All Files
Subscribers
imp

Details

Reviewers
gnn
philip
Commits
rS341203: sfxge(4): make RxQ type data an union
Summary

The type is an internal interface. Single integer is insufficient
to carry RxQ type-specific information in the case of equal stride
super-buffer Rx mode (packet buffers per bucket, maximum DMA length,
packet stride, head of line block timeout).

Sponsored by: Solarflare Communications, Inc.

Test Plan

amd64 tinderbox kernel builds tested
driver loaded/unloaded, interfaces up/down, traffic works fine

Diff Detail

Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 21092
Build 20455: arc lint + arc unit

Event Timeline

arybchik created this revision.Nov 21 2018, 11:49 AM
Harbormaster completed remote builds in B21092: Diff 50833.Nov 21 2018, 11:49 AM
This revision was not accepted when it landed; it landed in state Needs Review.Nov 29 2018, 6:45 AM
Closed by commit rS341203: sfxge(4): make RxQ type data an union (authored by arybchik). · Explain Why
This revision was automatically updated to reflect the committed changes.
Herald added a subscriber: imp. · View Herald TranscriptNov 29 2018, 6:45 AM

Revision Contents
Changeset List

PathSize
sys/
dev/
sfxge/
common/
4 lines
4 lines
13 lines
18 lines

Diff 50833

View Options

sys/dev/sfxge/common/ef10_impl.h

Loading...
View Options

sys/dev/sfxge/common/ef10_rx.c

Loading...
View Options

sys/dev/sfxge/common/efx_impl.h

Loading...
View Options

sys/dev/sfxge/common/efx_rx.c

Loading...