Page MenuHomeFreeBSD
Differential D18170

sfxge(4): add efsys macro to get memory region size
ClosedPublic
Actions

Authored by arybchik on Nov 21 2018, 11:38 AM.
Tags
None
Referenced Files
F114717136: D18170.id51197.diff
Tue, Apr 15, 9:00 PM
Unknown Object (File)
Mon, Apr 14, 11:11 AM
Unknown Object (File)
Feb 17 2025, 2:45 AM
Unknown Object (File)
Feb 1 2025, 9:49 AM
Unknown Object (File)
Jan 16 2025, 7:07 AM
Unknown Object (File)
Nov 30 2024, 3:24 AM
Unknown Object (File)
Oct 27 2024, 2:16 AM
Unknown Object (File)
Oct 4 2024, 11:36 PM
View All 34 Files
Subscribers
imp

Details

Reviewers
gnn
philip
Commits
rS341052: sfxge(4): handle new speeds in link events
rS341051: sfxge(4): add efsys macro to get memory region size
Summary

EFSYS_MEM_SIZE() reports the DMA mapped size of an efsys_mem_t
allocated region (the allocation size may be different due to
memory allocator and DMA alignment restrictions).

This ensures that common code internals have explicit knowledge
of the usable size of DMA mapped memory regions.

Submitted by: Andy Moreton <amoreton at solarflare.com>
Sponsored by: Solarflare Communications, Inc.

Test Plan

amd64 tinderbox kernel builds tested
driver loaded/unloaded, interfaces up/down, traffic works fine

Diff Detail

Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 21028
Build 20391: arc lint + arc unit

Event Timeline

arybchik created this revision.Nov 21 2018, 11:38 AM
Harbormaster completed remote builds in B21028: Diff 50769.Nov 21 2018, 11:38 AM
This revision was not accepted when it landed; it landed in state Needs Review.Nov 27 2018, 1:02 PM
Closed by commit rS341052: sfxge(4): handle new speeds in link events (authored by arybchik). · Explain Why
This revision was automatically updated to reflect the committed changes.
Herald added a subscriber: imp. · View Herald TranscriptNov 27 2018, 1:02 PM
arybchik mentioned this in D18171: sfxge(4): handle new speeds in link events.Nov 27 2018, 2:13 PM

Revision Contents
Changeset List

PathSize
sys/
dev/
sfxge/
common/
9 lines
11 lines
16 lines
11 lines
4 lines
9 lines
2 lines

Diff 50769

View Options

sys/dev/sfxge/common/ef10_rx.c

Show First 20 Lines • Show All 159 Lines • ▼ Show 20 Linesagain:
* We have a winner! * We have a winner!
*/ */
fbt = malloc(sizeof (fbt_probe_t), M_FBT, M_WAITOK | M_ZERO); fbt = malloc(sizeof (fbt_probe_t), M_FBT, M_WAITOK | M_ZERO);
fbt->fbtp_name = name; fbt->fbtp_name = name;
if (retfbt == NULL) { if (retfbt == NULL) {
fbt->fbtp_id = dtrace_probe_create(fbt_id, modname, fbt->fbtp_id = dtrace_probe_create(fbt_id, modname,
name, FBT_RETURN, 2, fbt); name, FBT_RETURN, 2, fbt);
} else { } else {
retfbt->fbtp_next = fbt; retfbt->fbtp_probenext = fbt;
fbt->fbtp_id = retfbt->fbtp_id; fbt->fbtp_id = retfbt->fbtp_id;
} }
retfbt = fbt; retfbt = fbt;
fbt->fbtp_patchpoint = instr; fbt->fbtp_patchpoint = instr;
fbt->fbtp_ctl = lf; fbt->fbtp_ctl = lf;
fbt->fbtp_loadcnt = lf->loadcnt; fbt->fbtp_loadcnt = lf->loadcnt;
fbt->fbtp_symindx = symindx; fbt->fbtp_symindx = symindx;
Show All 14 Lines
View Options

sys/dev/sfxge/common/ef10_tx.c

Show First 20 Lines • Show All 159 Lines • ▼ Show 20 Linesagain:
* We have a winner! * We have a winner!
*/ */
fbt = malloc(sizeof (fbt_probe_t), M_FBT, M_WAITOK | M_ZERO); fbt = malloc(sizeof (fbt_probe_t), M_FBT, M_WAITOK | M_ZERO);
fbt->fbtp_name = name; fbt->fbtp_name = name;
if (retfbt == NULL) { if (retfbt == NULL) {
fbt->fbtp_id = dtrace_probe_create(fbt_id, modname, fbt->fbtp_id = dtrace_probe_create(fbt_id, modname,
name, FBT_RETURN, 2, fbt); name, FBT_RETURN, 2, fbt);
} else { } else {
retfbt->fbtp_next = fbt; retfbt->fbtp_probenext = fbt;
fbt->fbtp_id = retfbt->fbtp_id; fbt->fbtp_id = retfbt->fbtp_id;
} }
retfbt = fbt; retfbt = fbt;
fbt->fbtp_patchpoint = instr; fbt->fbtp_patchpoint = instr;
fbt->fbtp_ctl = lf; fbt->fbtp_ctl = lf;
fbt->fbtp_loadcnt = lf->loadcnt; fbt->fbtp_loadcnt = lf->loadcnt;
fbt->fbtp_symindx = symindx; fbt->fbtp_symindx = symindx;
Show All 14 Lines
View Options

sys/dev/sfxge/common/efsys.h

Show First 20 Lines • Show All 159 Lines • ▼ Show 20 Linesagain:
* We have a winner! * We have a winner!
*/ */
fbt = malloc(sizeof (fbt_probe_t), M_FBT, M_WAITOK | M_ZERO); fbt = malloc(sizeof (fbt_probe_t), M_FBT, M_WAITOK | M_ZERO);
fbt->fbtp_name = name; fbt->fbtp_name = name;
if (retfbt == NULL) { if (retfbt == NULL) {
fbt->fbtp_id = dtrace_probe_create(fbt_id, modname, fbt->fbtp_id = dtrace_probe_create(fbt_id, modname,
name, FBT_RETURN, 2, fbt); name, FBT_RETURN, 2, fbt);
} else { } else {
retfbt->fbtp_next = fbt; retfbt->fbtp_probenext = fbt;
fbt->fbtp_id = retfbt->fbtp_id; fbt->fbtp_id = retfbt->fbtp_id;
} }
retfbt = fbt; retfbt = fbt;
fbt->fbtp_patchpoint = instr; fbt->fbtp_patchpoint = instr;
fbt->fbtp_ctl = lf; fbt->fbtp_ctl = lf;
fbt->fbtp_loadcnt = lf->loadcnt; fbt->fbtp_loadcnt = lf->loadcnt;
fbt->fbtp_symindx = symindx; fbt->fbtp_symindx = symindx;
Show All 14 Lines
View Options

sys/dev/sfxge/common/efx_intr.c

Show First 20 Lines • Show All 159 Lines • ▼ Show 20 Linesagain:
* We have a winner! * We have a winner!
*/ */
fbt = malloc(sizeof (fbt_probe_t), M_FBT, M_WAITOK | M_ZERO); fbt = malloc(sizeof (fbt_probe_t), M_FBT, M_WAITOK | M_ZERO);
fbt->fbtp_name = name; fbt->fbtp_name = name;
if (retfbt == NULL) { if (retfbt == NULL) {
fbt->fbtp_id = dtrace_probe_create(fbt_id, modname, fbt->fbtp_id = dtrace_probe_create(fbt_id, modname,
name, FBT_RETURN, 2, fbt); name, FBT_RETURN, 2, fbt);
} else { } else {
retfbt->fbtp_next = fbt; retfbt->fbtp_probenext = fbt;
fbt->fbtp_id = retfbt->fbtp_id; fbt->fbtp_id = retfbt->fbtp_id;
} }
retfbt = fbt; retfbt = fbt;
fbt->fbtp_patchpoint = instr; fbt->fbtp_patchpoint = instr;
fbt->fbtp_ctl = lf; fbt->fbtp_ctl = lf;
fbt->fbtp_loadcnt = lf->loadcnt; fbt->fbtp_loadcnt = lf->loadcnt;
fbt->fbtp_symindx = symindx; fbt->fbtp_symindx = symindx;
Show All 14 Lines
View Options

sys/dev/sfxge/common/efx_mcdi.c

Loading...
View Options

sys/dev/sfxge/common/siena_phy.c

Loading...
View Options

sys/dev/sfxge/sfxge_dma.c

Loading...