Differential D18130

sfxge(4): remove Falcon-specific concurrency check
ClosedPublic
Actions

Authored by arybchik on Nov 21 2018, 11:27 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sat, Jan 18, 1:41 AM

	Unknown Object (File)
	Nov 5 2024, 8:51 AM

	Unknown Object (File)
	Sep 23 2024, 7:20 AM

	Unknown Object (File)
	Sep 19 2024, 1:23 AM

	Unknown Object (File)
	Sep 18 2024, 10:29 PM

	Unknown Object (File)
	Sep 4 2024, 2:32 PM

	Unknown Object (File)
	Aug 19 2024, 1:57 PM

	Unknown Object (File)
	Jan 11 2024, 9:59 PM

View All 15 Files

Subscribers

Details

Reviewers

gnn
philip

Commits

rS342331: MFC r340896
rS340896: sfxge(4): remove Falcon-specific concurrency check

Summary

Falcon support has been withdrawn from libefx, however, there is still
an obsolete Falcon-specific assertion that efx_mac_stats_upload()
and efx_port_poll() aren't concurrent. To be consistent with an overall
Falcon support revocation it's desirable to remove it.

Fix debug build invalid assertion failure.

Submitted by: Ivan Malov <ivan.malov at oktetlabs.ru>
Sponsored by: Solarflare Communications, Inc.
MFC after: 1 week

Test Plan

amd64 tinderbox kernel builds tested
driver loaded/unloaded, interfaces up/down, traffic works fine

Diff Detail

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 20986
Build 20351: arc lint + arc unit

Event Timeline

arybchik created this revision.Nov 21 2018, 11:27 AM

Harbormaster completed remote builds in B20986: Diff 50727.Nov 21 2018, 11:27 AM

This revision was not accepted when it landed; it landed in state Needs Review.Nov 24 2018, 4:32 PM

Closed by commit rS340896: sfxge(4): remove Falcon-specific concurrency check (authored by arybchik). · Explain Why

This revision was automatically updated to reflect the committed changes.

Herald added a subscriber: imp. · View Herald TranscriptNov 24 2018, 4:32 PM

Revision Contents
Changeset List

Path

Size

sys/

dev/

sfxge/

common/

1 line

9 lines

1 line

Diff 50727

sys/dev/sfxge/common/efx_impl.h

Loading...

sys/dev/sfxge/common/efx_mac.c

Loading...

sys/dev/sfxge/common/efx_port.c

Loading...