sfxge(4): fix warnings from VS2015 C compiler (C4057)
ClosedPublic
Actions

Authored by arybchik on Nov 21 2018, 11:26 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Tue, Dec 2, 12:11 AM

	Unknown Object (File)
	Nov 25 2025, 12:28 PM

	Unknown Object (File)
	Nov 20 2025, 9:56 PM

	Unknown Object (File)
	Nov 20 2025, 9:56 PM

	Unknown Object (File)
	Nov 20 2025, 9:56 PM

	Unknown Object (File)
	Nov 20 2025, 9:47 PM

	Unknown Object (File)
	Nov 2 2025, 6:11 AM

	Unknown Object (File)
	Oct 26 2025, 6:06 AM

View All 83 Files

Subscribers

imp

Details

Reviewers

gnn
philip

Commits

rS342503: MFC r340890
rS342432: MFC r340890
rS342326: MFC r340890
rS340890: sfxge(4): fix warnings from VS2015 C compiler (C4057)

Summary

Fix two level 4 warnings
"C4057: 'function': 'const uint8_t *' differs in indirection to
slightly different base types from 'caddr_t'"; no functional changes.

Submitted by: Andrew Lee <alee at solarflare.com>
Sponsored by: Solarflare Communications, Inc.
MFC after: 1 week

Test Plan

amd64 tinderbox kernel builds tested
driver loaded/unloaded, interfaces up/down, traffic works fine

Diff Detail

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 20980
Build 20345: arc lint + arc unit

Event Timeline

arybchik created this revision.Nov 21 2018, 11:26 AM

Harbormaster completed remote builds in B20980: Diff 50721.Nov 21 2018, 11:26 AM

This revision was not accepted when it landed; it landed in state Needs Review.Nov 24 2018, 4:32 PM

Closed by commit rS340890: sfxge(4): fix warnings from VS2015 C compiler (C4057) (authored by arybchik). · Explain Why

This revision was automatically updated to reflect the committed changes.

Herald added a subscriber: imp. · View Herald TranscriptNov 24 2018, 4:32 PM

Revision Contents
Changeset List

Path

Size

sys/

dev/

sfxge/

common/

efx.h

4 lines

efx_bootcfg.c

6 lines

Diff 50721

View Options

sys/dev/sfxge/common/efx.h