Page MenuHomeFreeBSD
Differential D18123

sfxge(4): fix warnings from VS2015 C compiler (C4189)
ClosedPublic
Actions

Authored by arybchik on Nov 21 2018, 11:26 AM.
Tags
None
Referenced Files
F154848954: D18123.id51060.diff
Wed, Apr 29, 2:26 PM
F154846454: D18123.id50720.diff
Wed, Apr 29, 2:21 PM
F154846300: D18123.id51060.diff
Wed, Apr 29, 2:21 PM
F154843096: D18123.id50720.diff
Wed, Apr 29, 2:13 PM
Unknown Object (File)
Mon, Apr 27, 3:49 PM
Unknown Object (File)
Sat, Apr 25, 8:41 PM
Unknown Object (File)
Thu, Apr 23, 10:47 AM
Unknown Object (File)
Thu, Apr 23, 4:42 AM
View All Files
Subscribers
imp

Details

Reviewers
gnn
philip
Commits
rS342502: MFC r340889
rS342431: MFC r340889
rS342325: MFC r340889
rS340889: sfxge(4): fix warnings from VS2015 C compiler (C4189)
Summary

Fix multiple level 4 warnings
"C4189: 'xxx': local variable is initialized but not referenced";
no functional changes.

Submitted by: Andrew Lee <alee at solarflare.com>
Sponsored by: Solarflare Communications, Inc.
MFC after: 1 week

Test Plan

amd64 tinderbox kernel builds tested
driver loaded/unloaded, interfaces up/down, traffic works fine

Diff Detail

Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 20979
Build 20344: arc lint + arc unit

Event Timeline

arybchik created this revision.Nov 21 2018, 11:26 AM
Harbormaster completed remote builds in B20979: Diff 50720.Nov 21 2018, 11:26 AM
This revision was not accepted when it landed; it landed in state Needs Review.Nov 24 2018, 4:39 PM
Closed by commit rS340889: sfxge(4): fix warnings from VS2015 C compiler (C4189) (authored by arybchik). · Explain Why
This revision was automatically updated to reflect the committed changes.
Herald added a subscriber: imp. · View Herald TranscriptNov 24 2018, 4:39 PM

Revision Contents
Changeset List

PathSize
sys/
dev/
sfxge/
common/
7 lines
4 lines
4 lines
11 lines

Diff 50720

View Options

sys/dev/sfxge/common/ef10_ev.c

Loading...
View Options

sys/dev/sfxge/common/efx_ev.c

Loading...
View Options

sys/dev/sfxge/common/efx_tx.c

Loading...
View Options

sys/dev/sfxge/common/mcdi_mon.c

Loading...