sfxge(4): fix warnings from VS2015 C compiler (C4245)
ClosedPublic
Actions

Authored by arybchik on Nov 21 2018, 11:25 AM.

Tags

None

Referenced Files

	F167127202: D18121.diff
	Wed, Aug 19, 8:07 AM

	Unknown Object (File)
	Fri, Aug 14, 8:43 PM

	Unknown Object (File)
	Wed, Aug 12, 10:56 AM

	Unknown Object (File)
	Tue, Aug 11, 8:32 AM

	Unknown Object (File)
	Tue, Aug 11, 2:56 AM

	Unknown Object (File)
	Sat, Aug 8, 11:16 PM

	Unknown Object (File)
	Sat, Aug 8, 4:33 PM

	Unknown Object (File)
	Sat, Aug 8, 1:58 PM

View All Files

Subscribers

imp

Details

Reviewers

gnn
philip

Commits

rS342500: MFC r340887
rS342429: MFC r340887
rS342323: MFC r340887
rS340887: sfxge(4): fix warnings from VS2015 C compiler (C4245)

Summary

Fix level 4 warning
"C4245: 'initializing': conversion from 'int' to 'uint32_t',
signed/unsigned mismatch" warning; no functional changes.

Submitted by: Andrew Lee <alee at solarflare.com>
Sponsored by: Solarflare Communications, Inc.
MFC after: 1 week

Test Plan

amd64 tinderbox kernel builds tested
driver loaded/unloaded, interfaces up/down, traffic works fine

Diff Detail

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 20977
Build 20342: arc lint + arc unit

Event Timeline

arybchik created this revision.Nov 21 2018, 11:25 AM

Harbormaster completed remote builds in B20977: Diff 50718.Nov 21 2018, 11:25 AM

This revision was not accepted when it landed; it landed in state Needs Review.Nov 24 2018, 4:32 PM

Closed by commit rS340887: sfxge(4): fix warnings from VS2015 C compiler (C4245) (authored by arybchik). · Explain Why

This revision was automatically updated to reflect the committed changes.

Herald added a subscriber: imp. · View Herald TranscriptNov 24 2018, 4:32 PM

Revision Contents
Changeset List

Path

Size

sys/

dev/

sfxge/

common/

ef10_filter.c

2 lines

efx.h

54 lines

Diff 50718

View Options

sys/dev/sfxge/common/ef10_filter.c