Page MenuHomeFreeBSD
Differential D18121

sfxge(4): fix warnings from VS2015 C compiler (C4245)
ClosedPublic
Actions

Authored by arybchik on Nov 21 2018, 11:25 AM.
Tags
None
Referenced Files
F136989671: D18121.id51057.diff
Thu, Nov 20, 10:33 PM
F136987908: D18121.id.diff
Thu, Nov 20, 10:26 PM
F136987704: D18121.id50718.diff
Thu, Nov 20, 10:25 PM
F136986264: D18121.diff
Thu, Nov 20, 10:19 PM
Unknown Object (File)
Tue, Nov 18, 6:47 PM
Unknown Object (File)
Tue, Nov 18, 11:07 AM
Unknown Object (File)
Thu, Nov 6, 5:10 AM
Unknown Object (File)
Thu, Oct 30, 1:17 PM
View All 76 Files
Subscribers
imp

Details

Reviewers
gnn
philip
Commits
rS342500: MFC r340887
rS342429: MFC r340887
rS342323: MFC r340887
rS340887: sfxge(4): fix warnings from VS2015 C compiler (C4245)
Summary

Fix level 4 warning
"C4245: 'initializing': conversion from 'int' to 'uint32_t',
signed/unsigned mismatch" warning; no functional changes.

Submitted by: Andrew Lee <alee at solarflare.com>
Sponsored by: Solarflare Communications, Inc.
MFC after: 1 week

Test Plan

amd64 tinderbox kernel builds tested
driver loaded/unloaded, interfaces up/down, traffic works fine

Diff Detail

Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 20977
Build 20342: arc lint + arc unit

Event Timeline

arybchik created this revision.Nov 21 2018, 11:25 AM
Harbormaster completed remote builds in B20977: Diff 50718.Nov 21 2018, 11:25 AM
This revision was not accepted when it landed; it landed in state Needs Review.Nov 24 2018, 4:32 PM
Closed by commit rS340887: sfxge(4): fix warnings from VS2015 C compiler (C4245) (authored by arybchik). · Explain Why
This revision was automatically updated to reflect the committed changes.
Herald added a subscriber: imp. · View Herald TranscriptNov 24 2018, 4:32 PM

Revision Contents
Changeset List

PathSize
sys/
dev/
sfxge/
common/
2 lines
54 lines

Diff 50718

View Options

sys/dev/sfxge/common/ef10_filter.c

Loading...
View Options

sys/dev/sfxge/common/efx.h

Loading...