Page MenuHomeFreeBSD
Differential D18118

sfxge(4): fix probes in licensing support
ClosedPublic
Actions

Authored by arybchik on Nov 21 2018, 11:25 AM.
Tags
None
Referenced Files
F165259813: D18118.id50715.diff
Fri, Aug 7, 6:04 AM
F165243899: D18118.id50715.diff
Fri, Aug 7, 3:17 AM
F165187485: D18118.id50715.diff
Thu, Aug 6, 2:55 PM
Unknown Object (File)
Thu, Aug 6, 2:22 AM
Unknown Object (File)
Wed, Aug 5, 5:06 AM
Unknown Object (File)
Sat, Jul 25, 3:58 PM
Unknown Object (File)
Sat, Jul 18, 5:12 PM
Unknown Object (File)
May 28 2026, 12:24 PM
View All Files
Subscribers
imp

Details

Reviewers
gnn
philip
Commits
rS342497: MFC r340884
rS342426: MFC r340884
rS342316: MFC r340884
rS340884: sfxge(4): fix probes in licensing support
Summary

EFSYS_PROBE1 takes one typed value (in addition to the probe name),
whereas EFSYS_PROBE has just the probe name.

Which to use is determined by the probe name – “fail1” probes are
expected to include the function result.

Submitted by: Mark Spender <mspender at solarflare.com>
Sponsored by: Solarflare Communications, Inc.
MFC after: 1 week

Test Plan

amd64 tinderbox kernel builds tested
driver loaded/unloaded, interfaces up/down, traffic works fine

Diff Detail

Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 20974
Build 20339: arc lint + arc unit

Event Timeline

arybchik created this revision.Nov 21 2018, 11:25 AM
Harbormaster completed remote builds in B20974: Diff 50715.Nov 21 2018, 11:25 AM
This revision was not accepted when it landed; it landed in state Needs Review.Nov 24 2018, 4:32 PM
Closed by commit rS340884: sfxge(4): fix probes in licensing support (authored by arybchik). · Explain Why
This revision was automatically updated to reflect the committed changes.
Herald added a subscriber: imp. · View Herald TranscriptNov 24 2018, 4:32 PM

Revision Contents
Changeset List

PathSize
sys/
dev/
sfxge/
common/
6 lines

Diff 50715

View Options

sys/dev/sfxge/common/efx_lic.c

Loading...