sfxge(4): fix build issue with PHY LED control enabled
ClosedPublic
Actions

Authored by arybchik on Nov 21 2018, 11:24 AM.

Details

Reviewers

gnn
philip

Commits

rS342495: MFC r340875
rS342424: MFC r340875
rS342314: MFC r340875
rS340875: sfxge(4): fix build issue with PHY LED control enabled

Summary

Fixed build issue with the EFSYS_OPT_PHY_LED_CONTROL for Huntigton and
Medford.

Submitted by: Vijay Srivastava <vijays at solarflare.com>
Sponsored by: Solarflare Communications, Inc.
MFC after: 1 week

Test Plan

amd64 tinderbox kernel builds tested
driver loaded/unloaded, interfaces up/down, traffic works fine

Diff Detail

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 20966
Build 20331: arc lint + arc unit

Event Timeline

arybchik created this revision.Nov 21 2018, 11:24 AM

Harbormaster completed remote builds in B20966: Diff 50707.Nov 21 2018, 11:24 AM

This revision was not accepted when it landed; it landed in state Needs Review.Nov 24 2018, 3:23 PM

Closed by commit rS340875: sfxge(4): fix build issue with PHY LED control enabled (authored by arybchik). · Explain Why

This revision was automatically updated to reflect the committed changes.

Herald added a subscriber: imp. · View Herald TranscriptNov 24 2018, 3:23 PM

Revision Contents
Changeset List

Path

Size

sys/

dev/

sfxge/

common/

2 lines

4 lines

2 lines

2 lines

Diff 50707

View Options

sys/dev/sfxge/common/ef10_phy.c

View Options

sys/dev/sfxge/common/efx_check.h

View Options

sys/dev/sfxge/common/siena_nic.c

View Options

sys/dev/sfxge/common/siena_phy.c

sfxge(4): fix build issue with PHY LED control enabledClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 50707

sys/dev/sfxge/common/ef10_phy.c

sys/dev/sfxge/common/efx_check.h

sys/dev/sfxge/common/siena_nic.c

sys/dev/sfxge/common/siena_phy.c

sfxge(4): fix build issue with PHY LED control enabled
ClosedPublic
Actions

Revision Contents
Changeset List