sfxge(4): fix ignoring function return value
ClosedPublic
Actions

Authored by arybchik on Nov 21 2018, 11:21 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sat, Oct 10, 5:35 PM

	Unknown Object (File)
	Sun, Oct 4, 11:51 AM

	Unknown Object (File)
	Sat, Oct 3, 5:06 PM

	Unknown Object (File)
	Fri, Oct 2, 3:52 PM

	Unknown Object (File)
	Tue, Sep 29, 6:32 PM

	Unknown Object (File)
	Mon, Sep 21, 4:57 PM

	Unknown Object (File)
	Sep 16 2026, 12:15 PM

	Unknown Object (File)
	Sep 4 2026, 7:53 PM

View All Files

Subscribers

imp

Details

Reviewers

gnn
philip

Commits

rS342492: MFC r340826
rS342421: MFC r340826
rS342304: MFC r340826
rS340826: sfxge(4): fix ignoring function return value

Summary

fix PreFAST issue, add missing annotation that function return value
should not be ignored. Fix alignment.

Submitted by: Andy Moreton <amoreton at solarflare.com>
Sponsored by: Solarflare Communications, Inc.
MFC after: 1 week

Test Plan

amd64 tinderbox kernel builds tested
driver loaded/unloaded, interfaces up/down, traffic works fine

Diff Detail

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 20952
Build 20317: arc lint + arc unit

Event Timeline

arybchik created this revision.Nov 21 2018, 11:21 AM

Harbormaster completed remote builds in B20952: Diff 50692.Nov 21 2018, 11:21 AM

This revision was not accepted when it landed; it landed in state Needs Review.Nov 23 2018, 11:31 AM

Closed by commit rS340826: sfxge(4): fix ignoring function return value (authored by arybchik). · Explain Why

This revision was automatically updated to reflect the committed changes.

Herald added a subscriber: imp. · View Herald TranscriptNov 23 2018, 11:31 AM

Revision Contents
Changeset List

Path

Size

sys/

dev/

sfxge/

common/

efx.h

12 lines

efx_phy.c

2 lines

Diff 50692

View Options

sys/dev/sfxge/common/efx.h