sfxge(4): fix error code usage
ClosedPublic
Actions

Authored by arybchik on Nov 21 2018, 11:16 AM.

Tags

None

Referenced Files

	F133116583: D18069.diff
	Thu, Oct 23, 2:54 AM

	Unknown Object (File)
	Tue, Oct 14, 11:55 PM

	Unknown Object (File)
	Wed, Oct 8, 4:36 AM

	Unknown Object (File)
	Sat, Sep 27, 12:20 PM

	Unknown Object (File)
	Sat, Sep 27, 12:07 PM

	Unknown Object (File)
	Sep 22 2025, 7:06 PM

	Unknown Object (File)
	Sep 21 2025, 7:31 PM

	Unknown Object (File)
	Sep 12 2025, 4:47 PM

View All 76 Files

Subscribers

imp

Details

Reviewers

gnn
philip

Commits

rS342482: MFC r340799
rS342308: MFC r340799
rS340799: sfxge(4): fix error code usage

Summary

MCDI results returned in req.emr_rc have already been translated
from MC_CMD_ERR_* to errno names, so using an MC_CMD_ERR_* value
is incorrect.

Submitted by: Andy Moreton <amoreton at solarflare.com>
Sponsored by: Solarflare Communications, Inc.
MFC after: 1 week

Test Plan

amd64 tinderbox kernel builds tested
driver loaded/unloaded, interfaces up/down, traffic works fine

Diff Detail

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 20925
Build 20290: arc lint + arc unit

Event Timeline

arybchik created this revision.Nov 21 2018, 11:16 AM

Harbormaster completed remote builds in B20925: Diff 50665.Nov 21 2018, 11:17 AM

This revision was not accepted when it landed; it landed in state Needs Review.Nov 23 2018, 7:51 AM

Closed by commit rS340799: sfxge(4): fix error code usage (authored by arybchik). · Explain Why

This revision was automatically updated to reflect the committed changes.

Herald added a subscriber: imp. · View Herald TranscriptNov 23 2018, 7:51 AM

Revision Contents
Changeset List

Path

Size

sys/

dev/

sfxge/

common/

ef10_rx.c

2 lines

ef10_tx.c

2 lines

Diff 50665

View Options

sys/dev/sfxge/common/ef10_rx.c