Page MenuHomeFreeBSD
Differential D17830

lang/retro12: Update to 2018.8
ClosedPublic
Actions

Authored by 0mp on Nov 4 2018, 12:20 AM.
Tags
None
Referenced Files
F151037947: D17830.id50487.diff
Sun, Apr 5, 2:31 PM
F150993484: D17830.id50977.diff
Sun, Apr 5, 8:47 AM
F150908101: D17830.id.diff
Sat, Apr 4, 9:23 PM
Unknown Object (File)
Sat, Apr 4, 5:29 AM
Unknown Object (File)
Sat, Apr 4, 1:26 AM
Unknown Object (File)
Thu, Apr 2, 12:39 PM
Unknown Object (File)
Tue, Mar 31, 6:03 AM
Unknown Object (File)
Tue, Mar 24, 5:05 PM
View All Files
Subscribers
ndowens_yahoo.com

Details

Reviewers
mat
krion
Commits
rP485650: lang/retro12: Update to 2018.8
Summary

Changes to the port itself:

  • Fix the order of variables.
  • Set USES=shebangfix for the rre interpreter.

I'm the maintainer of this port.

Test Plan
  • poudriere
    • i386
      • 11.2
  • portlint OK

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 20838
Build 20220: arc lint + arc unit

Event Timeline

0mp created this revision.Nov 4 2018, 12:20 AM
Harbormaster completed remote builds in B20616: Diff 49981.Nov 4 2018, 12:20 AM
0mp added a comment.Nov 4 2018, 12:21 AM

I wonder if I should use pkg-plist here as we try to avoid using PORTDOCS and PORTEXAMPLES.

ndowens_yahoo.com added a subscriber: ndowens_yahoo.com.Nov 4 2018, 4:03 AM

In reply to the pkg-plist question around summary, plist should be in it's own file as it is more than 6 files.

lang/retro12/Makefile
52

Should be below TEST_TARGET, nothing should be after OPTIONS besides things such as post-install: and similar

krion marked an inline comment as done.Nov 5 2018, 9:09 PM
krion added inline comments.
lang/retro12/Makefile
19

Where is it used?

krion marked an inline comment as done.Nov 5 2018, 9:18 PM
krion added inline comments.
lang/retro12/Makefile
20

And why is this needed as well?

mat added inline comments.Nov 10 2018, 10:40 AM
lang/retro12/Makefile
19–20

Both _OLD_CMD and _CMD are already set correctly when setting SHEBANG_LANG.

0mp updated this revision to Diff 50487.Nov 16 2018, 1:31 PM
0mp marked 2 inline comments as not done.
  • Remove _OLD_CMD and _CMD.
  • Sort variables.
Harbormaster completed remote builds in B20838: Diff 50487.Nov 16 2018, 1:31 PM
0mp marked 6 inline comments as done.Nov 16 2018, 1:33 PM
0mp added inline comments.
lang/retro12/Makefile
19–20

Thanks, I didn't know about it.

52

You are right. Although, I thought for a second that *_TARGET variables should go to the targets' section.

0mp marked 2 inline comments as done.Nov 16 2018, 1:33 PM
mat accepted this revision.Nov 23 2018, 10:30 AM
This revision is now accepted and ready to land.Nov 23 2018, 10:30 AM
Closed by commit rP485650: lang/retro12: Update to 2018.8 (authored by 0mp). · Explain WhyNov 23 2018, 10:52 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
lang/
retro12/
12 lines
6 lines

Diff 50487

View Options

lang/retro12/Makefile

Loading...
View Options

lang/retro12/distinfo

Loading...