Page MenuHomeFreeBSD
Differential D17973

Fix /etc/ntp mode
ClosedPublic
Actions

Authored by garga on Nov 13 2018, 12:39 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Jul 21, 12:41 AM
Unknown Object (File)
Mon, Jul 20, 10:04 AM
Unknown Object (File)
Sat, Jul 18, 4:47 PM
Unknown Object (File)
Mon, Jul 6, 5:25 AM
Unknown Object (File)
Fri, Jul 3, 12:47 PM
Unknown Object (File)
Fri, Jul 3, 4:22 AM
Unknown Object (File)
Jun 22 2026, 2:03 PM
Unknown Object (File)
Jun 22 2026, 2:03 PM
View All Files
Subscribers
imp
yuripv

Details

Reviewers
brd
imp
Commits
rS340439: Fix /etc/ntp permissions. According to mtree it must be 0700
Summary

According to BSD.root.dist /etc/ntp should be 0700 but it's being created
as 0755 and every time installworld runs I see the following message:

etc/ntp:
        permissions (0700, 0755, modified)
crash:  permissions (0750, 0755, modified)

Change ntpd Makefile to make sure 0700 is used

MFC after: 3 days

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 20783
Build 20181: arc lint + arc unit

Event Timeline

garga created this revision.Nov 13 2018, 12:39 PM
Herald added a subscriber: imp. · View Herald TranscriptNov 13 2018, 12:39 PM
Harbormaster completed remote builds in B20783: Diff 50361.Nov 13 2018, 12:39 PM
garga edited the summary of this revision. (Show Details)Nov 13 2018, 12:40 PM
imp accepted this revision.Nov 13 2018, 2:46 PM
This revision is now accepted and ready to land.Nov 13 2018, 2:46 PM
garga added a comment.Nov 14 2018, 11:01 AM

Since I don't have a src bit, may I add "Approved by: imp"?

imp added a comment.Nov 14 2018, 3:39 PM
In D17973#384258, @garga wrote:

Since I don't have a src bit, may I add "Approved by: imp"?

Yes.

I assume that you've run buildworld / installworld and there's no ill effects from this and the files wind up having the proper permissions / ownership?

Closed by commit rS340439: Fix /etc/ntp permissions. According to mtree it must be 0700 (authored by garga). · Explain WhyNov 14 2018, 4:19 PM
This revision was automatically updated to reflect the committed changes.
yuripv added a subscriber: yuripv.Nov 14 2018, 4:31 PM
yuripv added inline comments.
head/usr.sbin/ntp/ntpd/Makefile
12 ↗(On Diff #50418)

Is ETN a typo or intentional?

garga marked an inline comment as done.Nov 14 2018, 6:11 PM
garga added inline comments.
head/usr.sbin/ntp/ntpd/Makefile
12 ↗(On Diff #50418)

typo, I'll commit a fix. Thanks!

Revision Contents
Changeset List

PathSize
usr.sbin/
ntp/
ntpd/
5 lines

Diff 50361

View Options

usr.sbin/ntp/ntpd/Makefile

Loading...