Page MenuHomeFreeBSD

Fix /etc/ntp mode
ClosedPublic

Authored by garga on Nov 13 2018, 12:39 PM.

Details

Summary

According to BSD.root.dist /etc/ntp should be 0700 but it's being created
as 0755 and every time installworld runs I see the following message:

etc/ntp:
        permissions (0700, 0755, modified)
crash:  permissions (0750, 0755, modified)

Change ntpd Makefile to make sure 0700 is used

MFC after: 3 days

Diff Detail

Repository
rS FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

garga created this revision.Nov 13 2018, 12:39 PM
garga edited the summary of this revision. (Show Details)Nov 13 2018, 12:40 PM
imp accepted this revision.Nov 13 2018, 2:46 PM
This revision is now accepted and ready to land.Nov 13 2018, 2:46 PM

Since I don't have a src bit, may I add "Approved by: imp"?

imp added a comment.Nov 14 2018, 3:39 PM

Since I don't have a src bit, may I add "Approved by: imp"?

Yes.

I assume that you've run buildworld / installworld and there's no ill effects from this and the files wind up having the proper permissions / ownership?

This revision was automatically updated to reflect the committed changes.
yuripv added a subscriber: yuripv.Nov 14 2018, 4:31 PM
yuripv added inline comments.
head/usr.sbin/ntp/ntpd/Makefile
12

Is ETN a typo or intentional?

garga marked an inline comment as done.Nov 14 2018, 6:11 PM
garga added inline comments.
head/usr.sbin/ntp/ntpd/Makefile
12

typo, I'll commit a fix. Thanks!