loader: ptable_open() check for ptable_cd9660read result is wrong
ClosedPublic
Actions

Authored by tsoome on Nov 7 2018, 1:50 PM.

Details

Reviewers

lev
cem

Commits

rS341225: MFC: r340240:
rS340240: loader: ptable_open() check for ptable_cd9660read result is wrong

Summary

bug 232483

The ptable_*read() functions return NULL on read errors (and partition table
closed as an side effect). The ptable_open must check the return value and
act properly.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 20684
Build 20099: arc lint + arc unit

Event Timeline

tsoome created this revision.Nov 7 2018, 1:50 PM

Herald added a subscriber: imp. · View Herald TranscriptNov 7 2018, 1:50 PM

Harbormaster completed remote builds in B20684: Diff 50118.Nov 7 2018, 1:50 PM

cem accepted this revision.Nov 7 2018, 7:23 PM

This revision is now accepted and ready to land.Nov 7 2018, 7:23 PM

This helps. It doen't show BSD partitions, but shows all four MBR slices without crash.

In D17890#382275, @lev wrote:

This helps. It doen't show BSD partitions, but shows all four MBR slices without crash.

Yes, because even the gpart does not list the partition types there (!0), so the loader part.c does not have knowledge about such layout. But thats another issue:)

Closed by commit rS340240: loader: ptable_open() check for ptable_cd9660read result is wrong (authored by tsoome). · Explain WhyNov 7 2018, 9:37 PM

This revision was automatically updated to reflect the committed changes.