Differential D17571

Get rid of unneccessary calls to lseek(2) from getgrent(3)
ClosedPublic
Actions

Authored by trasz on Oct 15 2018, 6:44 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Mon, Dec 16, 5:16 PM

	Unknown Object (File)
	Sep 26 2024, 3:22 PM

	Unknown Object (File)
	Sep 18 2024, 1:58 AM

	Unknown Object (File)
	Aug 29 2024, 2:05 AM

	Unknown Object (File)
	Aug 23 2024, 11:56 PM

	Unknown Object (File)
	Aug 21 2024, 7:21 PM

	Unknown Object (File)
	Aug 10 2024, 3:32 PM

	Unknown Object (File)
	Jul 28 2024, 3:46 AM

View All 38 Files

Subscribers

Details

Reviewers

kib
imp

Commits

rS339387: Get rid unneccessary useless calls to lseek(2) from getgrent(3).

Summary

Get rid unneccessary useless calls to lseek(2) from getgrent(3).
Looks like this:

fstatat(AT_FDCWD,"/etc/nsswitch.conf",{ mode=-rw-r--r-- ,inode=2167001,size=390,blksize=32768 },0x0) = 0 (0x0)
 open("/etc/group",O_RDONLY|O_CLOEXEC,0666)      = 3 (0x3)
 fstat(3,{ mode=-rw-r--r-- ,inode=2166927,size=919,blksize=32768 }) = 0 (0x0)
-lseek(3,0x0,SEEK_CUR)                           = 0 (0x0)
-lseek(3,0x0,SEEK_SET)                           = 0 (0x0)
 read(3,"# $FreeBSD: release/10.0.0/etc/g"...,32768) = 919 (0x397)
 close(3)                                        = 0 (0x0)

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 20222
Build 19701: arc lint + arc unit

Event Timeline

trasz created this revision.Oct 15 2018, 6:44 PM

Herald added a subscriber: imp. · View Herald TranscriptOct 15 2018, 6:44 PM

Harbormaster completed remote builds in B20222: Diff 49182.Oct 15 2018, 6:44 PM

Note that the '(!int)' syntax is to avoid spurious differences with the current style there.

trasz edited the summary of this revision. (Show Details)Oct 15 2018, 7:32 PM

kib accepted this revision.Oct 15 2018, 7:44 PM

This revision is now accepted and ready to land.Oct 15 2018, 7:44 PM

Closed by commit rS339387: Get rid unneccessary useless calls to lseek(2) from getgrent(3). (authored by trasz). · Explain WhyOct 16 2018, 6:17 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

lib/

libc/

gen/

48 lines

Diff 49182

lib/libc/gen/getgrent.c

Loading...