sysutils/flashrom: Enable buspirate interface by default
ClosedPublic
Actions

Authored by manu on Sep 28 2018, 7:08 PM.

Details

Reviewers

bapt
mizhka

Commits

Summary

Tested with my buspirate and two spi flash.
While here, pet portlint.

Repository

rP FreeBSD ports repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

mat added inline comments.Oct 1 2018, 1:17 PM

sysutils/flashrom/Makefile
35–41 ↗	(On Diff #48560)	BUSPIRATE_MAKE_ENV= CONFIG_BUSPIRATE_SPI=yes BUSPIRATE_MAKE_ENV_OFF= CONFIG_BUSPIRATE_SPI=no

manu marked an inline comment as done.Oct 1 2018, 1:25 PM

manu added inline comments.

sysutils/flashrom/Makefile
35–41 ↗	(On Diff #48560)	Thanks ! I was looking for something like that but couldn't find it in the handbook, I see it know of course.

This revision is now accepted and ready to land.Oct 2 2018, 2:55 PM

Always enable buspirate support since it's enabled by default upstream and just use serial port.

This revision now requires review to proceed.Oct 2 2018, 8:19 PM

manu marked an inline comment as done.Oct 2 2018, 8:20 PM

manu added inline comments.

sysutils/flashrom/Makefile
35–41 ↗	(On Diff #48560)	Just FYI it didn't worked, it was always compile with buspirate support despite the make config changes. Not a problem since we want to always have support for it since it's enabled by default upstream.