devel/libccid: Update to 1.4.30.
ClosedPublic
Actions

Authored by 0mp on Oct 9 2018, 9:44 AM.

Details

Reviewers

Commits

rP481886: devel/libccid: Update to 1.4.30

Summary

Test Plan

Repository

rP FreeBSD ports repository

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 20084
Build 19583: arc lint + arc unit

0mp created this revision.Oct 9 2018, 9:44 AM

0mp edited the summary of this revision. (Show Details)Oct 9 2018, 9:54 AM

This revision is now accepted and ready to land.Oct 10 2018, 1:00 PM

Thanks @krion, I'll wait for @mmokhi now.

Remove the "post-patch" target. It is no longer needed.

This revision now requires review to proceed.Oct 10 2018, 3:42 PM

0mp edited the summary of this revision. (Show Details)Oct 10 2018, 3:42 PM

devel/libccid/Makefile
31	Hi, Have you tested the port without this part in run-time and it was fine? [I could dogfood pcsc-lite, so I can ASSUME this should be also fine. but if you can confirm it works I'm fine otherwise if you can't test, would you mind if I ask for a bit of time to test 😅?]

devel/libccid/Makefile
31	Hello! Have you tested the port without this part in run-time and it was fine? Not really, no. I've not tested it in the run-time yet. However, those lines are not patching anything at this point. In 1.4.30: `contrib/Kobil_mIDentity_switch/Kobil_mIDentity_switch.c` no longer has any `__APPLE__` ifdefs (see https://github.com/LudovicRousseau/CCID/blob/ccid-1.4.30/contrib/Kobil_mIDentity_switch/Kobil_mIDentity_switch.c) `configure` from the distributed archive does not contain any `libusb-1.0/libusb.h` strings `src/ccid_usb.c`, `src/ccid_usb.h` and `contrib/Kobil_mIDentity_switch/Kobil_mIDentity_switch.c` are no longer hardcoding the path to libusb headers thanks to https://github.com/LudovicRousseau/CCID/commit/b4a4d2dc9679c5f8c3bd09ba60af7ec8dff6354c