Page MenuHomeFreeBSD
Differential D17293

x11-themes/slim-freebsd-black-theme: update to version 1.2.
ClosedPublic
Actions

Authored by rigoletto on Sep 22 2018, 6:06 PM.
Tags
None
Referenced Files
F166430025: D17293.id48363.diff
Thu, Aug 13, 1:07 PM
F166419898: D17293.id49118.diff
Thu, Aug 13, 12:28 PM
F166282791: D17293.id48918.diff
Wed, Aug 12, 4:41 PM
F166280339: D17293.id48920.diff
Wed, Aug 12, 4:26 PM
F166279134: D17293.id48398.diff
Wed, Aug 12, 4:22 PM
Unknown Object (File)
Wed, Aug 12, 1:13 PM
Unknown Object (File)
Tue, Aug 11, 11:17 PM
Unknown Object (File)
Mon, Aug 10, 5:23 PM
View All Files
Subscribers
None

Details

Reviewers
tcberner
mat
Commits
rP482017: x11-themes/slim-freebsd-black-theme: update to version 1.2.
Summary
  • update to version 1.2
  • update MAINTAINER
  • update MASTER_SITES
  • get rid of pkg-plist

Thanks.

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 20081
Build 19580: arc lint + arc unit

Event Timeline

rigoletto created this revision.Sep 22 2018, 6:06 PM
Herald added a subscriber: mat. · View Herald TranscriptSep 22 2018, 6:06 PM
Harbormaster completed remote builds in B19758: Diff 48363.Sep 22 2018, 6:06 PM
rigoletto edited the summary of this revision. (Show Details)Sep 22 2018, 6:08 PM
mat added inline comments.Sep 24 2018, 12:08 PM
x11-themes/slim-freebsd-black-theme/Makefile
18–19

This is only used once, It should probably go.

43

INSTALL_DATA.
Also, remove whitespace changes.

rigoletto updated this revision to Diff 48398.Sep 24 2018, 4:59 PM
rigoletto marked 2 inline comments as done.

Done.

Harbormaster completed remote builds in B19777: Diff 48398.Sep 24 2018, 4:59 PM
rigoletto updated this revision to Diff 48399.Sep 24 2018, 5:09 PM

Minor.

Harbormaster completed remote builds in B19778: Diff 48399.Sep 24 2018, 5:09 PM
rigoletto updated this revision to Diff 48703.Oct 4 2018, 4:41 AM

Updating MAINTAINER.

Harbormaster completed remote builds in B19948: Diff 48703.Oct 4 2018, 4:41 AM
rigoletto updated this revision to Diff 48844.Oct 7 2018, 2:00 AM

While here update MASTER_SITES to the new address.

Harbormaster completed remote builds in B20042: Diff 48844.Oct 7 2018, 2:00 AM
rigoletto retitled this revision from x11-themes/slim-freebsd-black-theme: update to version 1.1. to x11-themes/slim-freebsd-black-theme: update to version 1.2..Oct 7 2018, 2:15 AM
rigoletto edited the summary of this revision. (Show Details)
rigoletto added a reviewer: mat.
rigoletto removed a subscriber: mat.
rigoletto edited the summary of this revision. (Show Details)Oct 7 2018, 2:19 AM
rigoletto edited the summary of this revision. (Show Details)
mat added a comment.Oct 8 2018, 3:31 PM

Also, please provide a tentative commit message in your reviews.

x11-themes/slim-freebsd-black-theme/Makefile
19

Wrong place in the Makefile. See Chapter 15. Order of Variables in Port Makefiles.

rigoletto updated this revision to Diff 48918.Oct 9 2018, 3:35 AM
rigoletto marked an inline comment as done.

Done.

Harbormaster completed remote builds in B20079: Diff 48918.Oct 9 2018, 3:35 AM
rigoletto updated this revision to Diff 48920.Oct 9 2018, 3:39 AM

Correcting previous mistakes.

Thanks!

Harbormaster completed remote builds in B20081: Diff 48920.Oct 9 2018, 3:39 AM
rigoletto added a comment.Oct 9 2018, 8:36 PM

x11-themes/slim-freebsd-black-theme: update to version 1.2

Update MAINTAINER address.

Approved by: tcberner (mentor), mat (mentor)

mat added inline comments.Oct 13 2018, 2:25 PM
x11-themes/slim-freebsd-black-theme/Makefile
28–29

Wrong place in the Makefile. See Chapter 15. Order of Variables in Port Makefiles.

rigoletto updated this revision to Diff 49110.Oct 13 2018, 8:29 PM

Re-ordering.

Harbormaster completed remote builds in B20183: Diff 49110.Oct 13 2018, 8:29 PM
mat accepted this revision.Oct 13 2018, 9:06 PM
This revision is now accepted and ready to land.Oct 13 2018, 9:06 PM
Closed by commit rP482017: x11-themes/slim-freebsd-black-theme: update to version 1.2. (authored by rigoletto). · Explain WhyOct 13 2018, 9:31 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
x11-themes/
slim-freebsd-black-theme/
35 lines
6 lines

Diff 48920

View Options

x11-themes/slim-freebsd-black-theme/Makefile

Loading...
View Options

x11-themes/slim-freebsd-black-theme/distinfo

Loading...
View Options

x11-themes/slim-freebsd-black-theme/pkg-plist

Loading...