Tags

None

Referenced Files

	F142700886: D17445.id48815.diff
	Thu, Jan 22, 10:15 AM

	F142681441: D17445.id48816.diff
	Thu, Jan 22, 4:47 AM

	Unknown Object (File)
	Thu, Jan 22, 12:00 AM

	Unknown Object (File)
	Wed, Jan 21, 3:25 PM

	Unknown Object (File)
	Wed, Jan 21, 3:25 PM

	Unknown Object (File)
	Wed, Jan 21, 1:13 AM

	Unknown Object (File)
	Wed, Jan 21, 1:13 AM

	Unknown Object (File)
	Wed, Jan 21, 1:13 AM

View All Files

Subscribers

None

Details

Reviewers

mat

Group Reviewers

kde
portmgr

Commits

rP481446: net-im/telepathy-qt[45]: falvorize

Summary

Create flavors
Clean up Makefile

Diff Detail

Repository

rP FreeBSD ports repository

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 20019
Build 19523: arc lint + arc unit

Event Timeline

tcberner created this revision.Oct 6 2018, 12:13 AM

Harbormaster completed remote builds in B20019: Diff 48815.Oct 6 2018, 12:13 AM

Fix MOVED.lint

Harbormaster completed remote builds in B20020: Diff 48816.Oct 6 2018, 12:20 AM

mat added a reviewer: portmgr.Oct 6 2018, 8:22 AM

mat added inline comments.

net-im/telepathy-qt/Makefile
25	Wrong place in the Makefile. See Chapter 15. Order of Variables in Port Makefiles.
54–55	This could probably be `USES=uniquefiles:dirs`.

flavors bits looks good.

Reoder option, use uniquedir, and remove uneeded change in plist-sub

Harbormaster completed remote builds in B20025: Diff 48822.Oct 6 2018, 9:29 AM

uniquefiles:dirs didn't take, so I switched back to the maual override.

Harbormaster completed remote builds in B20026: Diff 48823.Oct 6 2018, 10:28 AM

This revision was not accepted when it landed; it landed in state Needs Review.Oct 7 2018, 1:43 PM

Closed by commit rP481446: net-im/telepathy-qt[45]: falvorize (authored by tcberner). · Explain Why

This revision was automatically updated to reflect the committed changes.

Flavorize net-im/telepathy-qt[45] -> net-im/telepathy-qt@[qt4,qt5]ClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 48815

MOVED

net-im/Makefile

net-im/ktp-accounts-kcm-kde4/Makefile

net-im/ktp-accounts-kcm/Makefile

net-im/ktp-approver-kde4/Makefile

net-im/ktp-approver/Makefile

net-im/ktp-auth-handler-kde4/Makefile

net-im/ktp-auth-handler/Makefile

net-im/ktp-call-ui/Makefile

net-im/ktp-common-internals-kde4/Makefile

net-im/ktp-common-internals/Makefile

net-im/ktp-contact-list-kde4/Makefile

net-im/ktp-contact-list/Makefile

net-im/ktp-contact-runner-kde4/Makefile

net-im/ktp-contact-runner/Makefile

net-im/ktp-filetransfer-handler-kde4/Makefile

net-im/ktp-filetransfer-handler/Makefile

net-im/ktp-kded-integration-module-kde4/Makefile

net-im/ktp-kded-module/Makefile

net-im/ktp-send-file-kde4/Makefile

net-im/ktp-send-file/Makefile

net-im/ktp-text-ui-kde4/Makefile

net-im/ktp-text-ui/Makefile

net-im/plasma-applet-ktp-kde4/Makefile

net-im/telepathy-logger-qt4/Makefile

net-im/telepathy-logger-qt5/Makefile

net-im/telepathy-qt/

net-im/telepathy-qt/Makefile

net-im/telepathy-qt4/

net-im/telepathy-qt4/Makefile

net-im/telepathy-qt4/distinfo

net-im/telepathy-qt4/pkg-descr

net-im/telepathy-qt4/pkg-plist

net-im/telepathy-qt5/

net-im/telepathy-qt5/Makefile

net/krdc-kde4/Makefile

net/krfb-kde4/Makefile

net/krfb/Makefile

www/choqok-kde4/Makefile

www/choqok/Makefile

Flavorize net-im/telepathy-qt[45] -> net-im/telepathy-qt@[qt4,qt5]
ClosedPublic
Actions

Revision Contents
Changeset List