Page MenuHomeFreeBSD

Flavorize net-im/telepathy-qt[45] -> net-im/telepathy-qt@[qt4,qt5]
ClosedPublic

Authored by tcberner on Oct 6 2018, 12:13 AM.

Details

Summary
  • Create flavors
  • Clean up Makefile

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 20025
Build 19529: arc lint + arc unit

Event Timeline

tcberner created this revision.Oct 6 2018, 12:13 AM
tcberner updated this revision to Diff 48816.Oct 6 2018, 12:20 AM

Fix MOVED.lint

mat added a reviewer: portmgr.Oct 6 2018, 8:22 AM
mat added inline comments.
net-im/telepathy-qt/Makefile
20–23

Wrong place in the Makefile. See Chapter 15. Order of Variables in Port Makefiles.

55–56

This could probably be USES=uniquefiles:dirs.

mat accepted this revision as: portmgr.Oct 6 2018, 8:23 AM

flavors bits looks good.

tcberner updated this revision to Diff 48822.Oct 6 2018, 9:29 AM

Reoder option, use uniquedir, and remove uneeded change in plist-sub

tcberner updated this revision to Diff 48823.Oct 6 2018, 10:28 AM

uniquefiles:dirs didn't take, so I switched back to the maual override.

This revision was not accepted when it landed; it landed in state Needs Review.Oct 7 2018, 1:43 PM
This revision was automatically updated to reflect the committed changes.