Details
- Reviewers
mat tcberner - Group Reviewers
kde - Commits
- rD52352: Introduce USES=qt to the Porter's Handbook
Diff Detail
- Repository
- rD FreeBSD doc repository - subversion
- Lint
No Lint Coverage - Unit
No Test Coverage - Build Status
Buildable 20002 Build 19508: arc lint + arc unit
Event Timeline
| en_US.ISO8859-1/books/porters-handbook/uses/chapter.xml | ||
|---|---|---|
| 2673 | Hmm, it doesn't seem to do anything in USES=qt. Looks like the usage comment at the top of qt.mk is not correct. | |
| en_US.ISO8859-1/books/porters-handbook/uses/chapter.xml | ||
|---|---|---|
| 2673 | no_env gets interpreted by qmake.mk | |
| en_US.ISO8859-1/books/porters-handbook/special/chapter.xml | ||
|---|---|---|
| 2612–2631 | I wonder if these paragraphs should be removed or moved to the qmake section instead (with QT_NONSTANDARD -> USES= qmake:no_env)? qt.mk does not seem to modify CONFIGURE_{ENV,ARGS} much on its own. | |
| 2868 | Should I a) remove the description of no_env and no_configure again? | |
| 2951 | Trying to build a port with just USES=qmake:5 or USES=qmake:4 fails with: Incorrect 'USES+= qmake' usage: argument '4' is not recognized. I'll remove the tip again. | |
| en_US.ISO8859-1/books/porters-handbook/special/chapter.xml | ||
|---|---|---|
| 2868 | I think I prefer c) something like "In most cases these are not needed" | |
| en_US.ISO8859-1/books/porters-handbook/special/chapter.xml | ||
|---|---|---|
| 2612–2631 | Ah, yes, QT_NONSTANDARD was removed some time ago, I missed that. | |
| 2868 | I would phrase this a bit differently, something along the lines of if the software breaks this or that way, use no_env/no_configure. The goal of the handbook is to help porters port software, it is better to say "use in this case" rather than "you will probably not need it". | |
| en_US.ISO8859-1/books/porters-handbook/uses/chapter.xml | ||
| 2673 | You should add no_env back, it is a valid argument, maybe saying that it is passed to qmake. | |
| en_US.ISO8859-1/books/porters-handbook/special/chapter.xml | ||
|---|---|---|
| 2868 |
| |