Page MenuHomeFreeBSD
Differential D17350

sysutils/flashrom: Enable buspirate interface by default
ClosedPublic
Actions

Authored by manu on Sep 28 2018, 7:08 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Nov 21, 12:59 AM
Unknown Object (File)
Wed, Nov 19, 1:07 PM
Unknown Object (File)
Wed, Nov 19, 3:01 AM
Unknown Object (File)
Wed, Nov 19, 2:34 AM
Unknown Object (File)
Tue, Nov 18, 9:27 PM
Unknown Object (File)
Tue, Nov 18, 7:37 AM
Unknown Object (File)
Sun, Nov 9, 6:10 PM
Unknown Object (File)
Sun, Nov 9, 5:51 PM
View All Files
Subscribers
mat

Details

Reviewers
bapt
mizhka
Commits
rP481795: sysutils/flashrom: Enable buspirate interface by default
Summary

Tested with my buspirate and two spi flash.
While here, pet portlint.

Diff Detail

Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 19964
Build 19474: arc lint + arc unit

Event Timeline

manu created this revision.Sep 28 2018, 7:08 PM
Herald added a subscriber: mat. · View Herald TranscriptSep 28 2018, 7:08 PM
Harbormaster completed remote builds in B19867: Diff 48560.Sep 28 2018, 7:08 PM
mat added inline comments.Oct 1 2018, 1:17 PM
sysutils/flashrom/Makefile
33–34
BUSPIRATE_MAKE_ENV=        CONFIG_BUSPIRATE_SPI=yes
BUSPIRATE_MAKE_ENV_OFF=    CONFIG_BUSPIRATE_SPI=no
manu marked an inline comment as done.Oct 1 2018, 1:25 PM
manu added inline comments.
sysutils/flashrom/Makefile
33–34

Thanks ! I was looking for something like that but couldn't find it in the handbook, I see it know of course.

mizhka accepted this revision.Oct 2 2018, 2:55 PM
This revision is now accepted and ready to land.Oct 2 2018, 2:55 PM
manu updated this revision to Diff 48658.Oct 2 2018, 8:19 PM

Always enable buspirate support since it's enabled by default upstream and just use serial port.

This revision now requires review to proceed.Oct 2 2018, 8:19 PM
Harbormaster completed remote builds in B19915: Diff 48658.Oct 2 2018, 8:19 PM
manu marked an inline comment as done.Oct 2 2018, 8:20 PM
manu added inline comments.
sysutils/flashrom/Makefile
33–34

Just FYI it didn't worked, it was always compile with buspirate support despite the make config changes.
Not a problem since we want to always have support for it since it's enabled by default upstream.

mat added inline comments.Oct 3 2018, 8:45 AM
sysutils/flashrom/Makefile
33–34

Remove.

34

Why += ?

manu marked 2 inline comments as done.Oct 3 2018, 9:16 AM
manu added inline comments.
sysutils/flashrom/Makefile
33–34

Right, will do.

34

Wasn't done by me, I'll fix it if necessary.

manu updated this revision to Diff 48725.Oct 4 2018, 3:11 PM

Remove bsd.ports.options.mk
Remove += for RUN_DEPEND

Harbormaster completed remote builds in B19964: Diff 48725.Oct 4 2018, 3:11 PM
manu marked 3 inline comments as done.Oct 4 2018, 3:11 PM
bapt accepted this revision.Oct 4 2018, 3:22 PM
This revision is now accepted and ready to land.Oct 4 2018, 3:22 PM
mizhka accepted this revision.Oct 8 2018, 8:39 AM
Closed by commit rP481795: sysutils/flashrom: Enable buspirate interface by default (authored by manu). · Explain WhyOct 11 2018, 9:12 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
sysutils/
flashrom/
12 lines

Diff 48725

View Options

sysutils/flashrom/Makefile

Loading...