amd64: reimplement libc memset and bzero with kernel memset
ClosedPublic
Actions

Authored by mjg on Sep 28 2018, 11:31 PM.

Tags

None

Referenced Files

	F105988500: D17355.id48565.diff
	Mon, Dec 23, 1:07 PM

	Unknown Object (File)
	Tue, Dec 3, 3:41 AM

	Unknown Object (File)
	Oct 7 2024, 6:45 AM

	Unknown Object (File)
	Sep 18 2024, 3:17 AM

	Unknown Object (File)
	Sep 8 2024, 2:42 PM

	Unknown Object (File)
	Sep 5 2024, 9:50 PM

	Unknown Object (File)
	Sep 1 2024, 6:56 AM

	Unknown Object (File)
	Aug 31 2024, 8:04 PM

View All 33 Files

Subscribers

imp

Details

Reviewers

kib

Commits

rS339077: amd64: reimplement libc memset and bzero with kernel memset

Summary

This is a depessimization, see r334537 for an explanation.

bzero was removed from the kernel but remains in libc. Macroify to accommodate differences to memset (no return value, always setting to 0).

The bzero.S file is left in place due to libc build magic which pulls in a C variant if a matching .S file is missing.

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 19871

Event Timeline

mjg created this revision.Sep 28 2018, 11:31 PM

Herald added a subscriber: imp. · View Herald TranscriptSep 28 2018, 11:31 PM

Harbormaster completed remote builds in B19871: Diff 48565.Sep 28 2018, 11:31 PM

kib accepted this revision.Sep 29 2018, 6:58 AM

This revision is now accepted and ready to land.Sep 29 2018, 6:58 AM

Closed by commit rS339077: amd64: reimplement libc memset and bzero with kernel memset (authored by mjg). · Explain WhyOct 1 2018, 8:39 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

lib/

libc/

amd64/

string/

bzero.S

48 lines

memset.S

112 lines

Diff 48565

View Options

lib/libc/amd64/string/bzero.S