Page MenuHomeFreeBSD

amd64: clean up copyin/copyout
ClosedPublic

Authored by mjg on Sep 22 2018, 11:45 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Aug 2, 10:04 AM
Unknown Object (File)
Mon, Jul 28, 10:37 PM
Unknown Object (File)
Jun 28 2025, 10:38 PM
Unknown Object (File)
Jun 23 2025, 7:10 AM
Unknown Object (File)
Jun 20 2025, 1:31 PM
Unknown Object (File)
Jun 18 2025, 7:54 AM
Unknown Object (File)
Jun 14 2025, 11:42 AM
Unknown Object (File)
Jun 11 2025, 8:36 AM
Subscribers

Details

Summary
  • move the PSL.AC comment to the fault handler
  • stop testing for zero-sized ops. after several minutes of package building there were no copyin calls with zero bytes and very few copyout. the semantic of returning 0 in this case is preserved
  • shorten exit paths by clearing %eax earlier
  • replace xchg with 3 movs. this is what compilers do. a naive benchmark on EPYC suggests about 1% increase in thoughput thanks to this change.
  • remove the uselss movb %cl,%al from copyout. it looks like a leftover from many years ago

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

movb is removed from copyin.

I am curious about the removal of xchg reg,reg.

This revision is now accepted and ready to land.Sep 22 2018, 4:46 PM
This revision was automatically updated to reflect the committed changes.