Page MenuHomeFreeBSD
Differential D17266

[NEW PORT] x11-themes/freebsd-8k-wallpapers
ClosedPublic
Actions

Authored by rigoletto on Sep 21 2018, 4:04 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Mar 6, 12:30 PM
Unknown Object (File)
Thu, Mar 6, 6:01 AM
Unknown Object (File)
Wed, Mar 5, 10:57 PM
Unknown Object (File)
Wed, Mar 5, 11:12 AM
Unknown Object (File)
Wed, Mar 5, 8:59 AM
Unknown Object (File)
Wed, Mar 5, 8:46 AM
Unknown Object (File)
Wed, Mar 5, 2:36 AM
Unknown Object (File)
Wed, Mar 5, 2:03 AM
View All Files
Subscribers
mat

Details

Reviewers
tcberner
adridg
mat
Group Reviewers
portmgr
Commits
rP480342: New ports: x11-themes/freebsd-8k-wallpapers and x11-themes/freebsd-8k…
Summary

Collection of simple FreeBSD 8K wallpapers, and it also include a KDE FLAVOR variation.

TODO:

  • write pkg-descr files [DONE]
  • tag version on the github repository [DONE]
Test Plan

The KDE version need testing on ---> KDE.

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 19717
Build 19280: arc lint + arc unit

Event Timeline

rigoletto created this revision.Sep 21 2018, 4:04 AM
Herald added a subscriber: mat. · View Herald TranscriptSep 21 2018, 4:04 AM
Harbormaster completed remote builds in B19712: Diff 48290.Sep 21 2018, 4:04 AM
tcberner added a comment.Sep 21 2018, 4:11 AM

A new port needs something else :) -- an entry to the categroy Makefile

rigoletto updated this revision to Diff 48291.Sep 21 2018, 4:12 AM

Minor.

Harbormaster completed remote builds in B19713: Diff 48291.Sep 21 2018, 4:12 AM
rigoletto added a comment.EditedSep 21 2018, 4:13 AM
In D17266#367943, @tcberner wrote:

A new port needs something else :) -- an entry to the categroy Makefile

I have did it already, just forgot to add to the review. :-D

rigoletto edited the summary of this revision. (Show Details)Sep 21 2018, 4:15 AM
rigoletto edited the test plan for this revision. (Show Details)
rigoletto updated this revision to Diff 48293.Sep 21 2018, 5:44 AM

pkg-descr ---> Done.

Harbormaster completed remote builds in B19715: Diff 48293.Sep 21 2018, 5:44 AM
rigoletto updated this revision to Diff 48294.Sep 21 2018, 5:46 AM

Minor.

Harbormaster completed remote builds in B19716: Diff 48294.Sep 21 2018, 5:46 AM
rigoletto updated this revision to Diff 48295.Sep 21 2018, 5:47 AM

Minor.

Harbormaster completed remote builds in B19717: Diff 48295.Sep 21 2018, 5:47 AM
rigoletto edited the summary of this revision. (Show Details)Sep 21 2018, 5:51 AM
rigoletto added a reviewer: adridg.Sep 21 2018, 5:58 AM
mat requested changes to this revision.Sep 21 2018, 8:34 AM

I am going to refuse flavors for this, it is subpackages, not flavors.

x11-themes/freebsd-8k-wallpapers/Makefile
28

So, the two flavors will conflict for no particular reason.

This revision now requires changes to proceed.Sep 21 2018, 8:34 AM
rigoletto updated this revision to Diff 48314.Sep 21 2018, 3:38 PM
rigoletto marked 2 inline comments as done.

Done.

Thanks.

Harbormaster completed remote builds in B19727: Diff 48314.Sep 21 2018, 3:38 PM
rigoletto updated this revision to Diff 48316.Sep 21 2018, 3:39 PM

Now done. :-)

Harbormaster completed remote builds in B19728: Diff 48316.Sep 21 2018, 3:39 PM
rigoletto edited the summary of this revision. (Show Details)Sep 22 2018, 12:34 AM
rigoletto updated this revision to Diff 48337.EditedSep 22 2018, 12:36 AM

Git repository tagged. Updating the ports.

Thanks.

Harbormaster completed remote builds in B19743: Diff 48337.Sep 22 2018, 12:36 AM
rigoletto updated this revision to Diff 48341.Sep 22 2018, 5:26 AM

Updating LICENSE.

Harbormaster completed remote builds in B19745: Diff 48341.Sep 22 2018, 5:26 AM
This revision was not accepted when it landed; it landed in state Needs Review.Sep 22 2018, 6:03 AM
Closed by commit rP480342: New ports: x11-themes/freebsd-8k-wallpapers and x11-themes/freebsd-8k… (authored by tcberner). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
x11-themes/
1 line
66 lines
3 lines
7 lines
100 lines
7 lines
50 lines

Diff 48295

View Options

x11-themes/Makefile

Show First 20 Lines • Show All 82 Lines • ▼ Show 20 Lines
static bool ia_need_loopback_route(const struct in_ifaddr *); static bool ia_need_loopback_route(const struct in_ifaddr *);
VNET_DEFINE_STATIC(int, nosameprefix); VNET_DEFINE_STATIC(int, nosameprefix);
#define V_nosameprefix VNET(nosameprefix) #define V_nosameprefix VNET(nosameprefix)
SYSCTL_INT(_net_inet_ip, OID_AUTO, no_same_prefix, CTLFLAG_VNET | CTLFLAG_RW, SYSCTL_INT(_net_inet_ip, OID_AUTO, no_same_prefix, CTLFLAG_VNET | CTLFLAG_RW,
&VNET_NAME(nosameprefix), 0, &VNET_NAME(nosameprefix), 0,
"Refuse to create same prefixes on different interfaces"); "Refuse to create same prefixes on different interfaces");
VNET_DEFINE_STATIC(bool, broadcast_lowest);
#define V_broadcast_lowest VNET(broadcast_lowest)
SYSCTL_BOOL(_net_inet_ip, OID_AUTO, broadcast_lowest, CTLFLAG_VNET | CTLFLAG_RW,
&VNET_NAME(broadcast_lowest), 0,
"Treat lowest address on a subnet (host 0) as broadcast");
VNET_DECLARE(struct inpcbinfo, ripcbinfo); VNET_DECLARE(struct inpcbinfo, ripcbinfo);
#define V_ripcbinfo VNET(ripcbinfo) #define V_ripcbinfo VNET(ripcbinfo)
static struct sx in_control_sx; static struct sx in_control_sx;
SX_SYSINIT(in_control_sx, &in_control_sx, "in_control"); SX_SYSINIT(in_control_sx, &in_control_sx, "in_control");
/* /*
* Return 1 if an internet address is for a ``local'' host * Return 1 if an internet address is for a ``local'' host
▲ Show 20 Lines • Show All 1,066 Lines • ▼ Show 20 Lines
} }
int int
in_ifaddr_broadcast(struct in_addr in, struct in_ifaddr *ia) in_ifaddr_broadcast(struct in_addr in, struct in_ifaddr *ia)
{ {
return ((in.s_addr == ia->ia_broadaddr.sin_addr.s_addr || return ((in.s_addr == ia->ia_broadaddr.sin_addr.s_addr ||
/* /*
* Check for old-style (host 0) broadcast, but * Optionally check for old-style (host 0) broadcast, but
* taking into account that RFC 3021 obsoletes it. * taking into account that RFC 3021 obsoletes it.
*/ */
(ia->ia_subnetmask != IN_RFC3021_MASK && (V_broadcast_lowest && ia->ia_subnetmask != IN_RFC3021_MASK &&
rgrimesUnsubmitted
Not Done
Inline Actions

There might be a micro optimization here to do the V_broadcast_zero test LAST, that way the additional test in the fast path only occurs after the tests we have been doing all along.

rgrimes: There might be a micro optimization here to do the V_broadcast_zero test LAST, that way the…
karelsAuthorUnsubmitted
Done
Inline Actions

Actually, I put it first as a micro-optimization. As it is false by default, the test fails immediately and we don't have to evaluate the rest.

karels: Actually, I put it first as a micro-optimization. As it is false by default, the test fails…
ntohl(in.s_addr) == ia->ia_subnet)) && ntohl(in.s_addr) == ia->ia_subnet)) &&
/* /*
* Check for an all one subnetmask. These * Check for an all one subnetmask. These
* only exist when an interface gets a secondary * only exist when an interface gets a secondary
* address. * address.
*/ */
ia->ia_subnetmask != (u_long)0xffffffff); ia->ia_subnetmask != (u_long)0xffffffff);
} }
▲ Show 20 Lines • Show All 521 Lines • Show Last 20 Lines
View Options

x11-themes/freebsd-8k-wallpapers/

Show First 20 Lines • Show All 82 Lines • ▼ Show 20 Lines
static bool ia_need_loopback_route(const struct in_ifaddr *); static bool ia_need_loopback_route(const struct in_ifaddr *);
VNET_DEFINE_STATIC(int, nosameprefix); VNET_DEFINE_STATIC(int, nosameprefix);
#define V_nosameprefix VNET(nosameprefix) #define V_nosameprefix VNET(nosameprefix)
SYSCTL_INT(_net_inet_ip, OID_AUTO, no_same_prefix, CTLFLAG_VNET | CTLFLAG_RW, SYSCTL_INT(_net_inet_ip, OID_AUTO, no_same_prefix, CTLFLAG_VNET | CTLFLAG_RW,
&VNET_NAME(nosameprefix), 0, &VNET_NAME(nosameprefix), 0,
"Refuse to create same prefixes on different interfaces"); "Refuse to create same prefixes on different interfaces");
VNET_DEFINE_STATIC(bool, broadcast_lowest);
#define V_broadcast_lowest VNET(broadcast_lowest)
SYSCTL_BOOL(_net_inet_ip, OID_AUTO, broadcast_lowest, CTLFLAG_VNET | CTLFLAG_RW,
&VNET_NAME(broadcast_lowest), 0,
"Treat lowest address on a subnet (host 0) as broadcast");
VNET_DECLARE(struct inpcbinfo, ripcbinfo); VNET_DECLARE(struct inpcbinfo, ripcbinfo);
#define V_ripcbinfo VNET(ripcbinfo) #define V_ripcbinfo VNET(ripcbinfo)
static struct sx in_control_sx; static struct sx in_control_sx;
SX_SYSINIT(in_control_sx, &in_control_sx, "in_control"); SX_SYSINIT(in_control_sx, &in_control_sx, "in_control");
/* /*
* Return 1 if an internet address is for a ``local'' host * Return 1 if an internet address is for a ``local'' host
▲ Show 20 Lines • Show All 1,066 Lines • ▼ Show 20 Lines
} }
int int
in_ifaddr_broadcast(struct in_addr in, struct in_ifaddr *ia) in_ifaddr_broadcast(struct in_addr in, struct in_ifaddr *ia)
{ {
return ((in.s_addr == ia->ia_broadaddr.sin_addr.s_addr || return ((in.s_addr == ia->ia_broadaddr.sin_addr.s_addr ||
/* /*
* Check for old-style (host 0) broadcast, but * Optionally check for old-style (host 0) broadcast, but
* taking into account that RFC 3021 obsoletes it. * taking into account that RFC 3021 obsoletes it.
*/ */
(ia->ia_subnetmask != IN_RFC3021_MASK && (V_broadcast_lowest && ia->ia_subnetmask != IN_RFC3021_MASK &&
rgrimesUnsubmitted
Not Done
Inline Actions

There might be a micro optimization here to do the V_broadcast_zero test LAST, that way the additional test in the fast path only occurs after the tests we have been doing all along.

rgrimes: There might be a micro optimization here to do the V_broadcast_zero test LAST, that way the…
karelsAuthorUnsubmitted
Done
Inline Actions

Actually, I put it first as a micro-optimization. As it is false by default, the test fails immediately and we don't have to evaluate the rest.

karels: Actually, I put it first as a micro-optimization. As it is false by default, the test fails…
ntohl(in.s_addr) == ia->ia_subnet)) && ntohl(in.s_addr) == ia->ia_subnet)) &&
/* /*
* Check for an all one subnetmask. These * Check for an all one subnetmask. These
* only exist when an interface gets a secondary * only exist when an interface gets a secondary
* address. * address.
*/ */
ia->ia_subnetmask != (u_long)0xffffffff); ia->ia_subnetmask != (u_long)0xffffffff);
} }
▲ Show 20 Lines • Show All 521 Lines • Show Last 20 Lines
View Options

x11-themes/freebsd-8k-wallpapers/Makefile

Show First 20 Lines • Show All 82 Lines • ▼ Show 20 Lines
static bool ia_need_loopback_route(const struct in_ifaddr *); static bool ia_need_loopback_route(const struct in_ifaddr *);
VNET_DEFINE_STATIC(int, nosameprefix); VNET_DEFINE_STATIC(int, nosameprefix);
#define V_nosameprefix VNET(nosameprefix) #define V_nosameprefix VNET(nosameprefix)
SYSCTL_INT(_net_inet_ip, OID_AUTO, no_same_prefix, CTLFLAG_VNET | CTLFLAG_RW, SYSCTL_INT(_net_inet_ip, OID_AUTO, no_same_prefix, CTLFLAG_VNET | CTLFLAG_RW,
&VNET_NAME(nosameprefix), 0, &VNET_NAME(nosameprefix), 0,
"Refuse to create same prefixes on different interfaces"); "Refuse to create same prefixes on different interfaces");
VNET_DEFINE_STATIC(bool, broadcast_lowest);
#define V_broadcast_lowest VNET(broadcast_lowest)
SYSCTL_BOOL(_net_inet_ip, OID_AUTO, broadcast_lowest, CTLFLAG_VNET | CTLFLAG_RW,
&VNET_NAME(broadcast_lowest), 0,
"Treat lowest address on a subnet (host 0) as broadcast");
VNET_DECLARE(struct inpcbinfo, ripcbinfo); VNET_DECLARE(struct inpcbinfo, ripcbinfo);
#define V_ripcbinfo VNET(ripcbinfo) #define V_ripcbinfo VNET(ripcbinfo)
static struct sx in_control_sx; static struct sx in_control_sx;
SX_SYSINIT(in_control_sx, &in_control_sx, "in_control"); SX_SYSINIT(in_control_sx, &in_control_sx, "in_control");
/* /*
* Return 1 if an internet address is for a ``local'' host * Return 1 if an internet address is for a ``local'' host
▲ Show 20 Lines • Show All 1,066 Lines • ▼ Show 20 Lines
} }
int int
in_ifaddr_broadcast(struct in_addr in, struct in_ifaddr *ia) in_ifaddr_broadcast(struct in_addr in, struct in_ifaddr *ia)
{ {
return ((in.s_addr == ia->ia_broadaddr.sin_addr.s_addr || return ((in.s_addr == ia->ia_broadaddr.sin_addr.s_addr ||
/* /*
* Check for old-style (host 0) broadcast, but * Optionally check for old-style (host 0) broadcast, but
* taking into account that RFC 3021 obsoletes it. * taking into account that RFC 3021 obsoletes it.
*/ */
(ia->ia_subnetmask != IN_RFC3021_MASK && (V_broadcast_lowest && ia->ia_subnetmask != IN_RFC3021_MASK &&
rgrimesUnsubmitted
Not Done
Inline Actions

There might be a micro optimization here to do the V_broadcast_zero test LAST, that way the additional test in the fast path only occurs after the tests we have been doing all along.

rgrimes: There might be a micro optimization here to do the V_broadcast_zero test LAST, that way the…
karelsAuthorUnsubmitted
Done
Inline Actions

Actually, I put it first as a micro-optimization. As it is false by default, the test fails immediately and we don't have to evaluate the rest.

karels: Actually, I put it first as a micro-optimization. As it is false by default, the test fails…
ntohl(in.s_addr) == ia->ia_subnet)) && ntohl(in.s_addr) == ia->ia_subnet)) &&
/* /*
* Check for an all one subnetmask. These * Check for an all one subnetmask. These
* only exist when an interface gets a secondary * only exist when an interface gets a secondary
* address. * address.
*/ */
ia->ia_subnetmask != (u_long)0xffffffff); ia->ia_subnetmask != (u_long)0xffffffff);
} }
▲ Show 20 Lines • Show All 521 Lines • Show Last 20 Lines
View Options

x11-themes/freebsd-8k-wallpapers/distinfo

Show First 20 Lines • Show All 82 Lines • ▼ Show 20 Lines
static bool ia_need_loopback_route(const struct in_ifaddr *); static bool ia_need_loopback_route(const struct in_ifaddr *);
VNET_DEFINE_STATIC(int, nosameprefix); VNET_DEFINE_STATIC(int, nosameprefix);
#define V_nosameprefix VNET(nosameprefix) #define V_nosameprefix VNET(nosameprefix)
SYSCTL_INT(_net_inet_ip, OID_AUTO, no_same_prefix, CTLFLAG_VNET | CTLFLAG_RW, SYSCTL_INT(_net_inet_ip, OID_AUTO, no_same_prefix, CTLFLAG_VNET | CTLFLAG_RW,
&VNET_NAME(nosameprefix), 0, &VNET_NAME(nosameprefix), 0,
"Refuse to create same prefixes on different interfaces"); "Refuse to create same prefixes on different interfaces");
VNET_DEFINE_STATIC(bool, broadcast_lowest);
#define V_broadcast_lowest VNET(broadcast_lowest)
SYSCTL_BOOL(_net_inet_ip, OID_AUTO, broadcast_lowest, CTLFLAG_VNET | CTLFLAG_RW,
&VNET_NAME(broadcast_lowest), 0,
"Treat lowest address on a subnet (host 0) as broadcast");
VNET_DECLARE(struct inpcbinfo, ripcbinfo); VNET_DECLARE(struct inpcbinfo, ripcbinfo);
#define V_ripcbinfo VNET(ripcbinfo) #define V_ripcbinfo VNET(ripcbinfo)
static struct sx in_control_sx; static struct sx in_control_sx;
SX_SYSINIT(in_control_sx, &in_control_sx, "in_control"); SX_SYSINIT(in_control_sx, &in_control_sx, "in_control");
/* /*
* Return 1 if an internet address is for a ``local'' host * Return 1 if an internet address is for a ``local'' host
▲ Show 20 Lines • Show All 1,066 Lines • ▼ Show 20 Lines
} }
int int
in_ifaddr_broadcast(struct in_addr in, struct in_ifaddr *ia) in_ifaddr_broadcast(struct in_addr in, struct in_ifaddr *ia)
{ {
return ((in.s_addr == ia->ia_broadaddr.sin_addr.s_addr || return ((in.s_addr == ia->ia_broadaddr.sin_addr.s_addr ||
/* /*
* Check for old-style (host 0) broadcast, but * Optionally check for old-style (host 0) broadcast, but
* taking into account that RFC 3021 obsoletes it. * taking into account that RFC 3021 obsoletes it.
*/ */
(ia->ia_subnetmask != IN_RFC3021_MASK && (V_broadcast_lowest && ia->ia_subnetmask != IN_RFC3021_MASK &&
rgrimesUnsubmitted
Not Done
Inline Actions

There might be a micro optimization here to do the V_broadcast_zero test LAST, that way the additional test in the fast path only occurs after the tests we have been doing all along.

rgrimes: There might be a micro optimization here to do the V_broadcast_zero test LAST, that way the…
karelsAuthorUnsubmitted
Done
Inline Actions

Actually, I put it first as a micro-optimization. As it is false by default, the test fails immediately and we don't have to evaluate the rest.

karels: Actually, I put it first as a micro-optimization. As it is false by default, the test fails…
ntohl(in.s_addr) == ia->ia_subnet)) && ntohl(in.s_addr) == ia->ia_subnet)) &&
/* /*
* Check for an all one subnetmask. These * Check for an all one subnetmask. These
* only exist when an interface gets a secondary * only exist when an interface gets a secondary
* address. * address.
*/ */
ia->ia_subnetmask != (u_long)0xffffffff); ia->ia_subnetmask != (u_long)0xffffffff);
} }
▲ Show 20 Lines • Show All 521 Lines • Show Last 20 Lines
View Options

x11-themes/freebsd-8k-wallpapers/kde.pkg-descr

Loading...
View Options

x11-themes/freebsd-8k-wallpapers/kde.pkg-plist

Loading...
View Options

x11-themes/freebsd-8k-wallpapers/pkg-descr

Loading...
View Options

x11-themes/freebsd-8k-wallpapers/pkg-plist

Loading...