getentropy(3): Trap non-API errnos from getrandom(2) and abort
ClosedPublic
Actions

Authored by cem on Sep 5 2018, 3:54 PM.

Tags

None

Referenced Files

	F171302651: D17050.id49363.diff
	Thu, Sep 10, 6:42 AM

	F171302359: D17050.diff
	Thu, Sep 10, 6:39 AM

	F171302319: D17050.id47701.diff
	Thu, Sep 10, 6:39 AM

	Unknown Object (File)
	Mon, Aug 24, 1:02 PM

	Unknown Object (File)
	Mon, Aug 24, 1:02 PM

	Unknown Object (File)
	Mon, Aug 24, 12:54 PM

	Unknown Object (File)
	Sat, Aug 15, 5:30 PM

	Unknown Object (File)
	Wed, Aug 12, 12:35 AM

View All Files

Subscribers

imp

Details

Reviewers

delphij

Commits

rS339496: getentropy(3): Trap non-API errnos from getrandom(2) and abort

Summary

Additionally, reconcile our abort behavior with arc4random(3). Unlike
SIGABRT, SIGKILL cannot be caught by the user program. These failures
are fatal conditions and should not return to the caller, as they did in
the instance that resulted in D17049.

While here, fix some minor typos in a comment.

Diff Detail

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 19420
Build 19017: arc lint + arc unit

Event Timeline

cem created this revision.Sep 5 2018, 3:54 PM

Harbormaster completed remote builds in B19420: Diff 47701.Sep 6 2018, 12:25 PM

LGTM

This revision is now accepted and ready to land.Sep 6 2018, 8:37 PM

Closed by commit rS339496: getentropy(3): Trap non-API errnos from getrandom(2) and abort (authored by cem). · Explain WhyOct 20 2018, 9:45 PM

This revision was automatically updated to reflect the committed changes.

Herald added a subscriber: imp. · View Herald TranscriptOct 20 2018, 9:45 PM

Revision Contents
Changeset List

Path

Size

lib/

libc/

gen/

getentropy.c

19 lines

Diff 47701

View Options

getentropy(3): Trap non-API errnos from getrandom(2) and abortClosedPublicActions