I'm not 100% sure how to create a golang port. It fails to find out packages
in the repository. I copy some directories in the repository to the library
search path in post-extract target, it worked.
Details
Details
- Reviewers
pi hrs - Commits
- rP478270: New port: devel/lazygit: Simple terminal UI for git commands
- portlint -AC looks fine
- poudriere test build finished successfully
- confirmed application actually works fine
Diff Detail
Diff Detail
- Repository
- rP FreeBSD ports repository
- Lint
No Lint Coverage - Unit
No Test Coverage - Build Status
Buildable 19086 Build 18714: arc lint + arc unit
Event Timeline
Comment Actions
Oops, Arcanist includes the whole diff in the repository in contrast svn only includes the current directory by default. Removed, irrerevant changes.
| devel/lazygit/Makefile | ||
|---|---|---|
| 5 | For new ports, set DISTVERSION instead of PORTVERSION. | |
| devel/lazygit/Makefile | ||
|---|---|---|
| 5 | Could you show me a pointer? Maybe somewhere in porter's handbook but I cannot find it. | |
| devel/lazygit/Makefile | ||
|---|---|---|
| 5 | ||
| devel/lazygit/Makefile | ||
|---|---|---|
| 5 | understood, thanks! | |
| devel/lazygit/Makefile | ||
|---|---|---|
| 21–25 | Can't all this be replaced with using GH_SUBDIR? | |
| devel/lazygit/Makefile | ||
|---|---|---|
| 21–25 | I think this is not the case for GH_SUBDIR. No additional distribution files needed. Everything's included in the distribution but the path is wrong. So I copy them to the path where go searches during the build. | |
Comment Actions
Will you update the new port to 0.1.80 before you commit ? Testbuilds look fine.
| devel/lazygit/Makefile | ||
|---|---|---|
| 25 | Why CP and not MV ? | |
| devel/lazygit/Makefile | ||
|---|---|---|
| 25 | Whichever is OK to me. | |