Page MenuHomeFreeBSD
Differential D16764

www/moinmoincli: A new port to edit MoinMoin wiki pages from a command line
ClosedPublic
Actions

Authored by 0mp on Aug 17 2018, 10:49 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Apr 6, 11:55 AM
Unknown Object (File)
Feb 25 2025, 9:20 AM
Unknown Object (File)
Feb 24 2025, 1:59 AM
Unknown Object (File)
Feb 4 2025, 9:42 PM
Unknown Object (File)
Jan 17 2025, 2:19 AM
Unknown Object (File)
Jan 2 2025, 1:43 AM
Unknown Object (File)
Nov 30 2024, 9:19 AM
Unknown Object (File)
Nov 30 2024, 9:19 AM
View All Files
Subscribers
sevan
thj

Details

Reviewers
krion
mat
Commits
rP477785: New port: www/moinmoincli: Edit MoinMoin wiki pages from a command line
Summary

Requested by: thj

Test Plan
  • portlint: OK
  • poudriere: 11.2 i386 OK

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 18926
Build 18576: arc lint + arc unit

Event Timeline

0mp created this revision.Aug 17 2018, 10:49 AM
Harbormaster completed remote builds in B18887: Diff 46828.Aug 17 2018, 10:49 AM
mat added inline comments.Aug 17 2018, 3:44 PM
www/moinmoincli/pkg-plist
3 ↗(On Diff #46828)

You need to add an EXAMPLES option to use PORTEXAMPLES.

0mp updated this revision to Diff 46863.Aug 17 2018, 9:21 PM

Remove %%PORTEXAMPLES%% from pkg-plist as the EXAMPLES option is not defined.

Harbormaster completed remote builds in B18912: Diff 46863.Aug 17 2018, 9:21 PM
0mp marked an inline comment as done.Aug 17 2018, 9:22 PM
0mp added inline comments.
www/moinmoincli/pkg-plist
3 ↗(On Diff #46828)

The configuration file is actually pretty important so I don't think I should add an EXAMPLES option.

0mp marked an inline comment as done.Aug 17 2018, 9:22 PM
mat added inline comments.Aug 18 2018, 9:52 AM
www/moinmoincli/Makefile
15

Wrong place in the Makefile. See Chapter 15. Order of Variables in Port Makefiles.

0mp updated this revision to Diff 46885.Aug 18 2018, 10:31 AM

Move SUB_FILES to the block for standard bsd.port.mk variables.

Thanks mat@!

Harbormaster completed remote builds in B18926: Diff 46885.Aug 18 2018, 10:32 AM
0mp updated this revision to Diff 46887.Aug 18 2018, 10:34 AM

Upload all the changes once again.

It turns out that "arc diff --update" has to reupload all the files everytime it's run.

Harbormaster completed remote builds in B18928: Diff 46887.Aug 18 2018, 10:34 AM
0mp marked 2 inline comments as done.Aug 22 2018, 10:58 AM

@mat, I think it's ready.

mat accepted this revision.Aug 22 2018, 11:34 AM
This revision is now accepted and ready to land.Aug 22 2018, 11:34 AM
Closed by commit rP477785: New port: www/moinmoincli: Edit MoinMoin wiki pages from a command line (authored by 0mp). · Explain WhyAug 22 2018, 1:20 PM
This revision was automatically updated to reflect the committed changes.
0mp added a comment.Aug 22 2018, 1:21 PM

Thanks, @mat!

Revision Contents
Changeset List

PathSize
www/
moinmoincli/
27 lines

Diff 46885

View Options

www/moinmoincli/Makefile

Loading...