Page MenuHomeFreeBSD
Differential D16768

Don't depend on implicit header dependencies in dtc
AbandonedPublic
Actions

Authored by arichardson on Aug 17 2018, 2:21 PM.
Tags
None
Referenced Files
F153299895: D16768.diff
Mon, Apr 20, 8:18 AM
Unknown Object (File)
Mon, Apr 6, 1:57 PM
Unknown Object (File)
Sun, Apr 5, 12:44 PM
Unknown Object (File)
Sat, Mar 28, 11:28 AM
Unknown Object (File)
Mar 15 2026, 12:45 AM
Unknown Object (File)
Mar 8 2026, 9:17 PM
Unknown Object (File)
Mar 7 2026, 4:40 AM
Unknown Object (File)
Mar 5 2026, 3:25 PM
View All 79 Files
Subscribers
None

Details

Reviewers
theraven
jhb
brooks
Summary

When building against libstdc++ these headers aren't pulled in implicitly

Test Plan

Fixes bootstrap of dtc on Linux

Diff Detail

Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 18893
Build 18547: arc lint + arc unit

Event Timeline

arichardson created this revision.Aug 17 2018, 2:21 PM
Harbormaster completed remote builds in B18893: Diff 46836.Aug 17 2018, 2:21 PM
theraven added a comment.Aug 17 2018, 3:08 PM

These changes look fine, but please send a PR on GitHub and then merge to FreeBSD from upstream.

arichardson added a comment.Aug 17 2018, 3:59 PM

I guess this is the correct repository? https://github.com/davidchisnall/dtc/pull/48

arichardson abandoned this revision.Aug 23 2018, 8:33 AM

Updated from upstream in rS338232

Revision Contents
Changeset List

PathSize
usr.bin/
dtc/
1 line
3 lines

Diff 46836

View Options

usr.bin/dtc/string.cc

Loading...
View Options

usr.bin/dtc/util.hh

Loading...