Paths

Table of Contentst

Differential D11118

usr.sbin/ndp: small fixes
ClosedPublic
Actions

Authored by garga on Jun 9 2017, 6:00 PM.

Tags

None

Referenced Files

	F136974180: D11118.id46614.diff
	Thu, Nov 20, 9:28 PM

	F136971260: D11118.id.diff
	Thu, Nov 20, 9:15 PM

	F136970863: D11118.id46613.diff
	Thu, Nov 20, 9:13 PM

	F136970533: D11118.id47158.diff
	Thu, Nov 20, 9:12 PM

	F136970490: D11118.id29388.diff
	Thu, Nov 20, 9:11 PM

	F136969253: D11118.diff
	Thu, Nov 20, 9:06 PM

	Unknown Object (File)
	Sun, Nov 9, 4:36 PM

	Unknown Object (File)
	Tue, Nov 4, 7:41 PM

Subscribers

Details

Reviewers

loos
allanjude
kevans

Commits

rS338243: usr.sbin/ndp: Cleanup in preparation to add libxo support

Summary

usr.sbin/ndp:

Constify rtpref_str declaration
Remove unused h_errno declaration
Use time_t type for expire
Use strlcpy to set static "?" value to ifname
Rename local variable 's' to stop shadowing global definition
Close socket used in pfx_flush()
Use local variables for sock() in setdefif() and getdefif()
Increase WARNS to 3

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 18759
Build 18434: arc lint + arc unit

Event Timeline

garga created this revision.Jun 9 2017, 6:00 PM

Herald added a subscriber: imp. · View Herald TranscriptJun 9 2017, 6:00 PM

Harbormaster completed remote builds in B9758: Diff 29388.Jun 9 2017, 6:00 PM

garga retitled this revision from usr.sbin/ntp: small fixes to usr.sbin/ndp: small fixes.Jun 9 2017, 6:19 PM

allanjude added a reviewer: allanjude.Jul 7 2018, 3:16 AM

garga added a reviewer: kevans.Aug 9 2018, 11:35 AM

kevans added inline comments.Aug 9 2018, 8:19 PM

usr.sbin/ndp/ndp.c
671–672	You might as well change this to `ifname == NULL` while you're touching the area, since ifname is actually a pointer.
672–675	ifname is actually NULL here, so the strlcpy dest and size should be of `ifix_buf` (and set `ifname = ifix_buf`)

Address @kevans comments

Harbormaster completed remote builds in B18758: Diff 46613.Aug 13 2018, 11:34 AM

Fixed reversed check

Harbormaster completed remote builds in B18759: Diff 46614.Aug 13 2018, 11:35 AM

Approved By: allanjude

This revision is now accepted and ready to land.Aug 21 2018, 4:59 PM

Closed by commit rS338243: usr.sbin/ndp: Cleanup in preparation to add libxo support (authored by garga). · Explain WhyAug 23 2018, 10:39 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

usr.sbin/

ndp/

2 lines

77 lines

Diff 46614

usr.sbin/ndp/Makefile

Loading...

usr.sbin/ndp/ndp.c

Loading...