Page MenuHomeFreeBSD
Differential D16641

Make ldconfig(8) atomic
ClosedPublic
Actions

Authored by trasz on Aug 9 2018, 11:13 AM.
Tags
None
Referenced Files
F166958032: D16641.diff
Tue, Aug 18, 3:41 AM
Unknown Object (File)
Mon, Aug 17, 6:00 PM
Unknown Object (File)
Fri, Aug 14, 12:54 PM
Unknown Object (File)
Fri, Aug 14, 2:55 AM
Unknown Object (File)
Wed, Aug 12, 3:56 AM
Unknown Object (File)
Mon, Aug 10, 8:18 PM
Unknown Object (File)
Mon, Aug 10, 6:38 PM
Unknown Object (File)
Sun, Aug 9, 9:52 PM
View All Files
Subscribers
imp

Details

Reviewers
imp
kib
Commits
rS337530: Make ldconfig(8) atomic, by removing an unneccessary call to unlink(2)
Summary

Make ldconfig(8) atomic, by removing an unneccessary call to unlink(2)
before rename(2).

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 18662
Build 18347: arc lint + arc unit

Event Timeline

trasz created this revision.Aug 9 2018, 11:13 AM
Herald added a subscriber: imp. · View Herald TranscriptAug 9 2018, 11:13 AM
Harbormaster completed remote builds in B18662: Diff 46455.Aug 9 2018, 11:13 AM
trasz added reviewers: imp, kib.Aug 9 2018, 11:14 AM
trasz updated this revision to Diff 46456.Aug 9 2018, 11:15 AM

Spurious empty line.

Harbormaster completed remote builds in B18663: Diff 46456.Aug 9 2018, 11:15 AM
kib accepted this revision.Aug 9 2018, 11:24 AM
This revision is now accepted and ready to land.Aug 9 2018, 11:24 AM
kib added inline comments.Aug 9 2018, 11:26 AM
sbin/ldconfig/ldconfig.c
522

This comment really marks both unlink() and rename() calls and could be preserved. It is arguably not too useful.

Closed by commit rS337530: Make ldconfig(8) atomic, by removing an unneccessary call to unlink(2) (authored by trasz). · Explain WhyAug 9 2018, 11:46 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
sbin/
ldconfig/
6 lines

Diff 46455

View Options

sbin/ldconfig/ldconfig.c

Loading...