Page MenuHomeFreeBSD
Differential D15958

x11-themes/qt[4,5]-style-Kvantum: update to v0.10.7 and convert to FLAVORs.
ClosedPublic
Actions

Authored by rigoletto on Jun 22 2018, 12:58 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Sep 11, 11:54 PM
Unknown Object (File)
Fri, Sep 11, 8:19 PM
Unknown Object (File)
Fri, Sep 11, 8:14 PM
Unknown Object (File)
Mon, Sep 7, 9:21 PM
Unknown Object (File)
Sun, Sep 6, 10:08 PM
Unknown Object (File)
Sun, Sep 6, 10:04 PM
Unknown Object (File)
Sun, Sep 6, 10:04 PM
Unknown Object (File)
Sun, Sep 6, 4:23 PM
View All Files
Subscribers
mat

Details

Reviewers
tcberner
rezny
Group Reviewers
portmgr
Commits
rP478124: x11-themes/qt[4,5]-style-Kvantum: update to v0.10.7 and convert to FLAVORs
Summary

PR: 227484

  • updated to v0.10.7
  • converted to FLAVORs.

Thanks!

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 18584
Build 18276: arc lint + arc unit

Event Timeline

rigoletto created this revision.Jun 22 2018, 12:58 AM
Herald added a subscriber: mat. · View Herald TranscriptJun 22 2018, 12:58 AM
Harbormaster completed remote builds in B17530: Diff 44280.Jun 22 2018, 12:58 AM
rigoletto added a comment.Jun 22 2018, 1:07 AM

Should CONFLICT_INSTALL be set with the old packages names?

Thanks!

tcberner added a comment.Jun 22 2018, 5:11 AM
In D15958#337880, @lbdm_privacychain.ch wrote:

Should CONFLICT_INSTALL be set with the old packages names?

Thanks!

Yeah, would not hurt I guess, and MOVED entries are required :)

tcberner added reviewers: rezny, portmgr.Jun 22 2018, 5:11 AM

Adding maintainer and portmgr (for flavors).

tcberner added a comment.Jun 22 2018, 5:13 AM

You should start with an "svn mv" of one of the old ones, so that there still is some of the history present.

mat added inline comments.Jun 22 2018, 9:59 AM
x11-themes/Kvantum/Makefile
4

For a new port, it should probably be DISTVERSION.

7

It would be better to also use flavor helpers for PKGNAMESUFFIX:

qt4_PKGNAMESUFFIX=  -qt4
qt5_PKGNAMESUFFIX=  -qt5
rigoletto updated this revision to Diff 44299.Jun 22 2018, 1:04 PM
rigoletto marked 2 inline comments as done.

Done.

Harbormaster completed remote builds in B17540: Diff 44299.Jun 22 2018, 1:04 PM
rigoletto updated this revision to Diff 44407.Jun 25 2018, 5:48 AM

I think I have to add the moved directory too.

Harbormaster completed remote builds in B17601: Diff 44407.Jun 25 2018, 5:48 AM
mat accepted this revision as: portmgr.Jun 27 2018, 11:01 AM

flavors look ok.

rigoletto updated this revision to Diff 44595.Jun 28 2018, 7:27 PM

Updating to use the new Qt USES.

Harbormaster completed remote builds in B17702: Diff 44595.Jun 28 2018, 7:27 PM
tcberner added a comment.Jun 30 2018, 7:19 AM

Could you update the PR on bugzilla with the new diff, and ask for maintainer feedback?

rigoletto updated this revision to Diff 46084.Jul 31 2018, 6:19 PM

Re-basing.

Harbormaster completed remote builds in B18462: Diff 46084.Jul 31 2018, 6:19 PM
rigoletto edited the summary of this revision. (Show Details)Jul 31 2018, 6:21 PM
tcberner added a comment.Jul 31 2018, 6:25 PM

I guess it's fine to call the timeout now :)

rigoletto updated this revision to Diff 46098.EditedJul 31 2018, 7:48 PM

Clean 'header' after re-basing.

Harbormaster completed remote builds in B18467: Diff 46098.Jul 31 2018, 7:48 PM
mat added inline comments.Aug 1 2018, 7:37 AM
x11-themes/Kvantum/Makefile
32–37
.elif ${FLAVOR} == qt5
rigoletto retitled this revision from x11-themes/qt[4,5]-style-Kvantum: update to v0.10.6 and convert to FLAVORs. to x11-themes/qt[4,5]-style-Kvantum: update to v0.10.7 and convert to FLAVORs..Aug 1 2018, 7:56 AM
rigoletto edited the summary of this revision. (Show Details)
rigoletto updated this revision to Diff 46121.Aug 1 2018, 8:40 AM
rigoletto marked an inline comment as done.

Version update + fixes.

Thanks!

Harbormaster completed remote builds in B18477: Diff 46121.Aug 1 2018, 8:40 AM
rigoletto updated this revision to Diff 46164.Aug 1 2018, 10:01 PM

Minor.

Harbormaster completed remote builds in B18508: Diff 46164.Aug 1 2018, 10:01 PM
tcberner added a comment.Aug 4 2018, 10:12 AM

You are missing the MOVED entries :)

rigoletto updated this revision to Diff 46290.Aug 4 2018, 5:56 PM

Adding MOVED.

Thanks!

Harbormaster completed remote builds in B18584: Diff 46290.Aug 4 2018, 5:56 PM
This revision was not accepted when it landed; it landed in state Needs Review.Aug 26 2018, 12:18 PM
Closed by commit rP478124: x11-themes/qt[4,5]-style-Kvantum: update to v0.10.7 and convert to FLAVORs (authored by tcberner). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
1 line
x11-themes/
Kvantum
qt4-style-Kvantum
Kvantum/
27 lines
6 lines
12 lines
2 lines
445 lines
3 lines
30 lines
3 lines
12 lines
2 lines
31 lines
3 lines
12 lines
436 lines

Diff 46290

View Options

MOVED

Loading...
View Options

x11-themes/Kvantum/

Loading...
View Options

x11-themes/Kvantum/Makefile

Loading...
View Options

x11-themes/Kvantum/distinfo

Loading...
View Options

x11-themes/Kvantum/pkg-descr

Loading...
View Options

x11-themes/Kvantum/pkg-plist

Loading...
View Options

x11-themes/Kvantum/pkg-plist.qt4

Loading...
View Options

x11-themes/Kvantum/pkg-plist.qt5

Loading...
View Options

x11-themes/Makefile

Loading...
View Options

x11-themes/qt4-style-Kvantum/

Loading...
View Options

x11-themes/qt4-style-Kvantum/Makefile

Loading...
View Options

x11-themes/qt4-style-Kvantum/distinfo

Loading...
View Options

x11-themes/qt4-style-Kvantum/pkg-descr

Loading...
View Options

x11-themes/qt4-style-Kvantum/pkg-plist

Loading...
View Options

x11-themes/qt5-style-Kvantum/

Loading...
View Options

x11-themes/qt5-style-Kvantum/Makefile

Loading...
View Options

x11-themes/qt5-style-Kvantum/distinfo

Loading...
View Options

x11-themes/qt5-style-Kvantum/pkg-descr

Loading...
View Options

x11-themes/qt5-style-Kvantum/pkg-plist

Loading...