Page MenuHomeFreeBSD
Differential D16586

Fix casts between 64-bit physical addresses and pointers in EFI.
ClosedPublic
Actions

Authored by jhb on Aug 3 2018, 9:00 PM.
Tags
None
Referenced Files
F169809818: D16586.id46906.diff
Wed, Sep 2, 3:27 PM
F169809812: D16586.id46270.diff
Wed, Sep 2, 3:27 PM
Unknown Object (File)
Sun, Aug 30, 7:21 PM
Unknown Object (File)
Sun, Aug 30, 7:21 PM
Unknown Object (File)
Sat, Aug 22, 4:53 AM
Unknown Object (File)
Wed, Aug 19, 11:33 PM
Unknown Object (File)
Tue, Aug 11, 6:32 PM
Unknown Object (File)
Tue, Aug 11, 6:31 PM
View All Files
Subscribers
None

Details

Reviewers
imp
kevans
Commits
rS338022: Fix casts between 64-bit physical addresses and pointers in EFI.
Summary

Compiling FreeBSD/i386 with modern GCC triggers warnings for various
places that convert 64-bit EFI_ADDRs to pointers and vice versa.

  • Cast pointers to uintptr_t rather than to uint64_t when assigning to a 64-bit integer.
  • Cast 64-bit integers to uintptr_t before a cast to a pointer.
Test Plan
  • build world with CROSS_TOOLCHAIN=i386-gcc

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 18569
Build 18264: arc lint + arc unit

Event Timeline

jhb created this revision.Aug 3 2018, 9:00 PM
Harbormaster completed remote builds in B18569: Diff 46270.Aug 3 2018, 9:00 PM
kevans accepted this revision.Aug 14 2018, 4:23 AM
This revision is now accepted and ready to land.Aug 14 2018, 4:23 AM
Closed by commit rS338022: Fix casts between 64-bit physical addresses and pointers in EFI. (authored by jhb). · Explain WhyAug 18 2018, 8:28 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
stand/
efi/
loader/
arch/
i386/
12 lines
2 lines
6 lines

Diff 46270

View Options

stand/efi/loader/arch/i386/efimd.c

Loading...
View Options

stand/efi/loader/bootinfo.c

Loading...
View Options

stand/efi/loader/copy.c

Loading...