Page MenuHomeFreeBSD

cd9660 pointer sign issues and missing __packed attribute
ClosedPublic

Authored by tsoome on Aug 2 2018, 10:16 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Aug 23, 8:22 PM
Unknown Object (File)
Sat, Aug 22, 5:55 PM
Unknown Object (File)
Sat, Aug 22, 9:36 AM
Unknown Object (File)
Wed, Aug 19, 4:55 PM
Unknown Object (File)
Tue, Aug 18, 9:27 PM
Unknown Object (File)
Tue, Aug 18, 8:29 PM
Unknown Object (File)
Tue, Aug 18, 8:05 PM
Unknown Object (File)
Tue, Aug 18, 6:22 PM
Subscribers

Details

Summary

the isonum_* functions are defined to take unsigend char* as an argument,
but the structure fields are defined as char. Change to u_char where needed.

Probably the full structure should be changed, but I'm not sure about the
side affects.

while there, add __packed attribute.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 18517
Build 18222: arc lint + arc unit

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Aug 15 2018, 6:42 AM
This revision was automatically updated to reflect the committed changes.