Page MenuHomeFreeBSD
Differential D16286

math/stp: Update to latest version 2.3.1.
ClosedPublic
Actions

Authored by arrowd on Jul 16 2018, 9:53 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Apr 29, 6:52 AM
Unknown Object (File)
Tue, Apr 23, 11:31 PM
Unknown Object (File)
Sat, Apr 20, 12:38 PM
Unknown Object (File)
Feb 16 2024, 12:55 PM
Unknown Object (File)
Feb 16 2024, 12:54 PM
Unknown Object (File)
Feb 16 2024, 12:54 PM
Unknown Object (File)
Feb 16 2024, 12:54 PM
Unknown Object (File)
Feb 16 2024, 12:54 PM
View All 46 Files
Subscribers
lwhsu

Details

Reviewers
tcberner
AMDmi3
Commits
rP475224: math/stp: Update to latest 2.3.1 version.
Summary

I've changed PORTVERSION from revision number to the correct one. How do I verify it doesn't go backwards for pkg and other tools?

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

arrowd created this revision.Jul 16 2018, 9:53 AM
Harbormaster completed remote builds in B18066: Diff 45358.Jul 16 2018, 9:53 AM
lwhsu added a subscriber: lwhsu.Jul 16 2018, 4:56 PM
$ pkg version -t 1436 2.3.1
>

So I am afraid that we need PORTEPOCH here. It was my fault that time...

tcberner added a comment.Jul 16 2018, 5:33 PM

You can find the documentation here.

arrowd updated this revision to Diff 45381.Jul 16 2018, 6:00 PM
  • Add PORTEPOCH and move USE_GITHUB into the right place.
Harbormaster completed remote builds in B18078: Diff 45381.Jul 16 2018, 6:00 PM
tcberner added inline comments.Jul 16 2018, 6:20 PM
math/stp/Makefile
16 ↗(On Diff #45381)

^ is it working now?

19 ↗(On Diff #45381)

^ could you check whether cmake:outsource works?

arrowd added inline comments.Jul 16 2018, 6:42 PM
math/stp/Makefile
16 ↗(On Diff #45381)

No idea. But how do we know?

tcberner added inline comments.Jul 16 2018, 6:46 PM
math/stp/Makefile
16 ↗(On Diff #45381)

Hehe, I think in that case I would leave it in.

arrowd updated this revision to Diff 45488.Jul 18 2018, 6:11 PM
  • Address comments.
Harbormaster completed remote builds in B18138: Diff 45488.Jul 18 2018, 6:11 PM
arrowd marked 2 inline comments as done.Jul 18 2018, 6:11 PM
tcberner accepted this revision.Jul 18 2018, 6:23 PM

with the mentioned change, it looks fine.

math/stp/Makefile
16 ↗(On Diff #45488)

^ please use a tab after "=" not a simple whitespace.

This revision is now accepted and ready to land.Jul 18 2018, 6:23 PM
Closed by commit rP475224: math/stp: Update to latest 2.3.1 version. (authored by arrowd). · Explain WhyJul 24 2018, 6:19 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
head/
math/
stp/
15 lines
5 lines
10 lines

Diff 45760

View Options

head/math/stp/Makefile

Loading...
View Options

head/math/stp/distinfo

Loading...
View Options

head/math/stp/pkg-plist

Loading...