Page MenuHomeFreeBSD
Differential D11287

Fix multiple Coverity warnings in tftpd(8)
ClosedPublic
Actions

Authored by asomers on Jun 20 2017, 11:13 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Jun 5, 12:52 PM
Unknown Object (File)
Tue, Jun 2, 6:56 AM
Unknown Object (File)
Sun, May 31, 7:41 PM
Unknown Object (File)
Tue, May 26, 9:26 PM
Unknown Object (File)
Tue, May 26, 9:26 PM
Unknown Object (File)
Fri, May 22, 2:10 PM
Unknown Object (File)
Apr 29 2026, 2:39 PM
Unknown Object (File)
Apr 29 2026, 2:32 PM
View All Files
Subscribers
cem

Details

Reviewers
imp
Commits
rS339059: MFC r336605:
rS339051: MFC r336605:
rS336605: Fix multiple Coverity warnings in tftpd(8)
Summary

Fix multiple Coverity warnings in tftpd(8)

  • Initialize uninitialized variable (CID 1006502)
  • Delete dead code (CID 1006796, 1006794, 1006793)
  • strcpy => strlcpy (CID 1006792, 1006791, 1006790)
  • Check function return values (CID 1009442, 1009441, 1009440)

CID: 1006502, 1006796, 1006794, 1006793, 1006792, 1006791, 1006790,
CID: 1009442, 1009441, 1009440

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

asomers created this revision.Jun 20 2017, 11:13 PM
asomers added a comment.Jul 10 2017, 11:18 PM

Actually, it turns out that the "dead code" wasn't dead after all; it's used by some files in the usr.bin/tftp directory. I need to restore those functions and fix their warnings the hard way.

cem added a subscriber: cem.Feb 9 2018, 8:52 PM
This revision was not accepted when it landed; it landed in state Needs Review.Jul 22 2018, 4:14 PM
Closed by commit rS336605: Fix multiple Coverity warnings in tftpd(8) (authored by asomers). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
head/
libexec/
tftpd/
4 lines
16 lines
4 lines
10 lines

Diff 45691

View Options

head/libexec/tftpd/tftp-file.c

Loading...
View Options

head/libexec/tftpd/tftp-io.c

Loading...
View Options

head/libexec/tftpd/tftp-utils.c

Loading...
View Options

head/libexec/tftpd/tftpd.c

Loading...