sysutils/rpi-firmware: Update to 1.20180619 and add rpi0-w config.txt
ClosedPublic
Actions

Authored by manu on Jul 12 2018, 10:02 AM.

Details

Reviewers

imp
linimon

Commits

rP475104: sysutils/rpi-firmware: Update to 1.20180619 and add rpi0-w config.txt

Diff Detail

Repository

rP FreeBSD ports repository

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

manu created this revision.Jul 12 2018, 10:02 AM

Herald added a subscriber: mat. · View Herald TranscriptJul 12 2018, 10:02 AM

linimon retitled this revision from rpi-firmware: Update to 1.20180619 and add rpi0-w config.txt to sysutils/rpi-firmware: Update to 1.20180619 and add rpi0-w config.txt.Jul 12 2018, 10:47 AM

linimon added a subscriber: linimon.

linimon requested changes to this revision.Jul 12 2018, 11:24 AM

linimon added inline comments.

sysutils/rpi-firmware/Makefile
30	If we expect this list to grow, I might suggest adding something like CONFIG_TXT_FILES=a b c above, and then adding an iterator here.

This revision now requires changes to proceed.Jul 12 2018, 11:24 AM

linimon added inline comments.Jul 12 2018, 1:02 PM

sysutils/rpi-firmware/Makefile
30	e.g. +CONFIG_TXT_FILES= config.txt config_rpi_0_w.txt config_rpi3.txt + do-patch: ${CP} ${FILESDIR}/config.txt ${WRKSRC}/boot/ ${CP} ${FILESDIR}/config_rpi3.txt ${WRKSRC}/boot/ +.for i in ${CONFIG_TXT_FILES} + ${CP} ${FILESDIR}/${i} ${WRKSRC}/boot/ +.endfor

linimon added inline comments.Jul 12 2018, 1:03 PM

sysutils/rpi-firmware/Makefile
30	phab handily removed my '^-' from the two existing CP lines.

manu added inline comments.Jul 12 2018, 1:08 PM

sysutils/rpi-firmware/Makefile
30	The list won't grow.

imp accepted this revision.Jul 12 2018, 3:21 PM

imp added inline comments.

sysutils/rpi-firmware/Makefile
30	famous last words.

manu added inline comments.Jul 12 2018, 3:53 PM

sysutils/rpi-firmware/Makefile
30	I guess it will when the RPI4 will be out. I'll do the for loop, this is not interesting to even talk about this :)

mat added inline comments.Jul 13 2018, 6:42 AM

sysutils/rpi-firmware/Makefile
30	Unless there are more than 3 files in the very close future, doing it this way is better/shorter. (Also, you could run CP only one with all the files, which would be even better.)