Page MenuHomeFreeBSD
Differential D16243

sysutils/rpi-firmware: Update to 1.20180619 and add rpi0-w config.txt
ClosedPublic
Actions

Authored by manu on Jul 12 2018, 10:02 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Apr 17, 4:17 AM
Unknown Object (File)
Mon, Apr 14, 8:07 AM
Unknown Object (File)
Mon, Apr 14, 4:51 AM
Unknown Object (File)
Sun, Apr 13, 10:34 PM
Unknown Object (File)
Sun, Apr 13, 10:23 PM
Unknown Object (File)
Sun, Apr 13, 9:25 PM
Unknown Object (File)
Sun, Mar 23, 11:52 PM
Unknown Object (File)
Feb 23 2025, 4:32 AM
View All 90 Files
Subscribers
linimon
mat

Details

Reviewers
imp
linimon
Commits
rP475104: sysutils/rpi-firmware: Update to 1.20180619 and add rpi0-w config.txt

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

manu created this revision.Jul 12 2018, 10:02 AM
Herald added a subscriber: mat. · View Herald TranscriptJul 12 2018, 10:02 AM
linimon retitled this revision from rpi-firmware: Update to 1.20180619 and add rpi0-w config.txt to sysutils/rpi-firmware: Update to 1.20180619 and add rpi0-w config.txt.Jul 12 2018, 10:47 AM
linimon added a subscriber: linimon.
linimon requested changes to this revision.Jul 12 2018, 11:24 AM
linimon added inline comments.
sysutils/rpi-firmware/Makefile
30

If we expect this list to grow, I might suggest adding something like

CONFIG_TXT_FILES=a b c

above, and then adding an iterator here.

This revision now requires changes to proceed.Jul 12 2018, 11:24 AM
linimon added inline comments.Jul 12 2018, 1:02 PM
sysutils/rpi-firmware/Makefile
30

e.g.

+CONFIG_TXT_FILES= config.txt config_rpi_0_w.txt config_rpi3.txt
+
do-patch:

  • ${CP} ${FILESDIR}/config.txt ${WRKSRC}/boot/
  • ${CP} ${FILESDIR}/config_rpi3.txt ${WRKSRC}/boot/

+.for i in ${CONFIG_TXT_FILES}
+ ${CP} ${FILESDIR}/${i} ${WRKSRC}/boot/
+.endfor

linimon added inline comments.Jul 12 2018, 1:03 PM
sysutils/rpi-firmware/Makefile
30

phab handily removed my '^-' from the two existing CP lines.

manu added inline comments.Jul 12 2018, 1:08 PM
sysutils/rpi-firmware/Makefile
30

The list won't grow.

imp accepted this revision.Jul 12 2018, 3:21 PM
imp added inline comments.
sysutils/rpi-firmware/Makefile
30

famous last words.

manu added inline comments.Jul 12 2018, 3:53 PM
sysutils/rpi-firmware/Makefile
30

I guess it will when the RPI4 will be out.
I'll do the for loop, this is not interesting to even talk about this :)

mat added inline comments.Jul 13 2018, 6:42 AM
sysutils/rpi-firmware/Makefile
30

Unless there are more than 3 files in the very close future, doing it this way is better/shorter. (Also, you could run CP only one with all the files, which would be even better.)

manu updated this revision to Diff 45457.Jul 18 2018, 1:12 PM
manu marked 7 inline comments as done.
This revision was not accepted when it landed; it landed in state Needs Review.Jul 22 2018, 12:00 PM
Closed by commit rP475104: sysutils/rpi-firmware: Update to 1.20180619 and add rpi0-w config.txt (authored by manu). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
sysutils/
rpi-firmware/
8 lines
6 lines
files/
1 line
6 lines
1 line

Diff 45457

View Options

sysutils/rpi-firmware/Makefile

# $FreeBSD$ # $FreeBSD$
PORTNAME= rpi-firmware PORTNAME= rpi-firmware
PORTVERSION= 1.20180328 PORTVERSION= 1.20180619
CATEGORIES= sysutils CATEGORIES= sysutils
MAINTAINER= manu@freebsd.org MAINTAINER= uboot@freebsd.org
COMMENT= Firmware for RaspberryPi Single Board Computer COMMENT= Firmware for RaspberryPi Single Board Computer
LICENSE= BROADCOM LICENSE= BROADCOM
LICENSE_NAME= Broadcom Corporation LICENSE_NAME= Broadcom Corporation
LICENSE_FILE= ${WRKSRC}/boot/LICENCE.broadcom LICENSE_FILE= ${WRKSRC}/boot/LICENCE.broadcom
LICENSE_PERMS= dist-mirror no-dist-sell pkg-mirror no-pkg-sell auto-accept LICENSE_PERMS= dist-mirror no-dist-sell pkg-mirror no-pkg-sell auto-accept
BUILD_DEPENDS= aarch64-none-elf-gcc:devel/aarch64-none-elf-gcc BUILD_DEPENDS= aarch64-none-elf-gcc:devel/aarch64-none-elf-gcc
USE_GITHUB= yes USE_GITHUB= yes
GH_ACCOUNT= raspberrypi gonzoua:pscimon GH_ACCOUNT= raspberrypi gonzoua:pscimon
GH_PROJECT= firmware rpi3-psci-monitor:pscimon GH_PROJECT= firmware rpi3-psci-monitor:pscimon
PSCI_TAG= 2b8890a PSCI_TAG= 2b8890a
GH_TAGNAME= ${PSCI_TAG}:pscimon GH_TAGNAME= ${PSCI_TAG}:pscimon
PSCI_MONITOR= rpi3-psci-monitor-${PSCI_TAG} PSCI_MONITOR= rpi3-psci-monitor-${PSCI_TAG}
PSCI_DIR= ${WRKDIR}/${PSCI_MONITOR} PSCI_DIR= ${WRKDIR}/${PSCI_MONITOR}
BUILD_WRKSRC= ${PSCI_DIR} BUILD_WRKSRC= ${PSCI_DIR}
INSTALL_DIR= ${PREFIX}/share/${PORTNAME} INSTALL_DIR= ${PREFIX}/share/${PORTNAME}
do-patch: do-patch:
${CP} ${FILESDIR}/config.txt ${WRKSRC}/boot/ ${CP} ${FILESDIR}/config.txt ${FILESDIR}/config_rpi_0_w.txt \
${CP} ${FILESDIR}/config_rpi3.txt ${WRKSRC}/boot/ ${FILESDIR}/config_rpi3.txt ${WRKSRC}/boot/
linimonUnsubmitted
Done
Inline Actions

If we expect this list to grow, I might suggest adding something like

CONFIG_TXT_FILES=a b c

above, and then adding an iterator here.

linimon: If we expect this list to grow, I might suggest adding something like CONFIG_TXT_FILES=a b c…
linimonUnsubmitted
Done
Inline Actions

e.g.

+CONFIG_TXT_FILES= config.txt config_rpi_0_w.txt config_rpi3.txt
+
do-patch:

  • ${CP} ${FILESDIR}/config.txt ${WRKSRC}/boot/
  • ${CP} ${FILESDIR}/config_rpi3.txt ${WRKSRC}/boot/

+.for i in ${CONFIG_TXT_FILES}
+ ${CP} ${FILESDIR}/${i} ${WRKSRC}/boot/
+.endfor

linimon: e.g. +CONFIG_TXT_FILES= config.txt config_rpi_0_w.txt config_rpi3.txt + do-patch…
linimonUnsubmitted
Done
Inline Actions

phab handily removed my '^-' from the two existing CP lines.

linimon: phab handily removed my '^-' from the two existing CP lines.
manuAuthorUnsubmitted
Done
Inline Actions

The list won't grow.

manu: The list won't grow.
impUnsubmitted
Done
Inline Actions

famous last words.

imp: famous last words.
manuAuthorUnsubmitted
Done
Inline Actions

I guess it will when the RPI4 will be out.
I'll do the for loop, this is not interesting to even talk about this :)

manu: I guess it will when the RPI4 will be out. I'll do the for loop, this is not interesting to…
matUnsubmitted
Done
Inline Actions

Unless there are more than 3 files in the very close future, doing it this way is better/shorter. (Also, you could run CP only one with all the files, which would be even better.)

mat: Unless there are more than 3 files in the very close future, doing it this way is…
post-patch: post-patch:
${RM} ${WRKSRC}/boot/kernel.img ${RM} ${WRKSRC}/boot/kernel.img
${RM} ${WRKSRC}/boot/kernel7.img ${RM} ${WRKSRC}/boot/kernel7.img
do-install: do-install:
${MKDIR} ${STAGEDIR}/${INSTALL_DIR} ${MKDIR} ${STAGEDIR}/${INSTALL_DIR}
cd ${WRKSRC}/boot && ${COPYTREE_SHARE} . ${STAGEDIR}/${INSTALL_DIR}/ cd ${WRKSRC}/boot && ${COPYTREE_SHARE} . ${STAGEDIR}/${INSTALL_DIR}/
${INSTALL_DATA} ${PSCI_DIR}/armstub8.bin ${STAGEDIR}/${INSTALL_DIR}/ ${INSTALL_DATA} ${PSCI_DIR}/armstub8.bin ${STAGEDIR}/${INSTALL_DIR}/
.include <bsd.port.mk> .include <bsd.port.mk>
View Options

sysutils/rpi-firmware/distinfo

TIMESTAMP = 1526136538 TIMESTAMP = 1530704759
SHA256 (raspberrypi-firmware-1.20180328_GH0.tar.gz) = 44731225495bb211353dd86fbead980f8bb62930a3ec6711ed7094aff2397758 SHA256 (raspberrypi-firmware-1.20180619_GH0.tar.gz) = e657478923220947321503ef980f3a6772d6f1e11b48c5c359bdb5e3d49355d9
SIZE (raspberrypi-firmware-1.20180328_GH0.tar.gz) = 122075858 SIZE (raspberrypi-firmware-1.20180619_GH0.tar.gz) = 122571494
SHA256 (gonzoua-rpi3-psci-monitor-2b8890a_GH0.tar.gz) = a7b89678adea178359646a1e95a078d5c60d23821ba355f27f14ed7b28f32f4d SHA256 (gonzoua-rpi3-psci-monitor-2b8890a_GH0.tar.gz) = a7b89678adea178359646a1e95a078d5c60d23821ba355f27f14ed7b28f32f4d
SIZE (gonzoua-rpi3-psci-monitor-2b8890a_GH0.tar.gz) = 5115 SIZE (gonzoua-rpi3-psci-monitor-2b8890a_GH0.tar.gz) = 5115
View Options

sysutils/rpi-firmware/files/config.txt

init_uart_clock=3000000 init_uart_clock=3000000
enable_uart=1 enable_uart=1
kernel=u-boot.bin kernel=u-boot.bin
kernel7=u-boot.bin kernel7=u-boot.bin
dtoverlay=mmc
View Options

sysutils/rpi-firmware/files/config_rpi_0_w.txt

  • This file was added.
init_uart_clock=3000000
enable_uart=1
kernel=u-boot.bin
kernel7=u-boot.bin
dtoverlay=mmc
dtoverlay=pi3-disable-bt
View Options

sysutils/rpi-firmware/pkg-plist

Loading...