Differential D16118

Extend amount of possible coredumps.
ClosedPublic
Actions

Authored by oshogbo on Jul 3 2018, 10:09 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Mon, Nov 18, 8:20 AM

	Unknown Object (File)
	Sun, Nov 17, 2:57 PM

	Unknown Object (File)
	Thu, Oct 31, 6:32 AM

	Unknown Object (File)
	Oct 22 2024, 9:19 AM

	Unknown Object (File)
	Oct 14 2024, 12:09 AM

	Unknown Object (File)
	Sep 23 2024, 10:23 AM

	Unknown Object (File)
	Sep 22 2024, 8:12 PM

	Unknown Object (File)
	Sep 22 2024, 7:47 PM

View All 45 Files

Subscribers

Details

Reviewers

Commits

rS336306: Extend amount of possible coredumps from 10 to 100000 when using index format.

Summary

The limitation of number of coredumps is removed.
The amount of digit in the name of corefile is assigned dynamically.

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

oshogbo created this revision.Jul 3 2018, 10:09 PM

Please regenerate the diff with the context.

sys/kern/kern_sig.c
3217	Where this define is used ?
3313	Why coding snprintf() by hands ?

Thanks @kib

oshogbo marked 2 inline comments as done.Jul 12 2018, 8:32 AM

kib added inline comments.Jul 12 2018, 10:09 AM

sys/kern/kern_sig.c
3331–3335	The blank line is not needed.
3444	I still do not understand why do you do this manually. How do you try to format the core file name ? printf() family has the format modifiers to align right ('-'), to fill the padding with zeroes ('0') and some other.

oshogbo updated this revision to Diff 45217.Jul 12 2018, 4:04 PM

oshogbo added inline comments.

sys/kern/kern_sig.c
3331–3335	I would prefer to separate those twos.
3444	Yeah, but I don't think wee need such sophisticated way. printf with max number should just work fine.

kib accepted this revision.Jul 12 2018, 4:29 PM

This revision is now accepted and ready to land.Jul 12 2018, 4:29 PM

Closed by commit rS336306: Extend amount of possible coredumps from 10 to 100000 when using index format. (authored by oshogbo). · Explain WhyJul 15 2018, 5:10 PM

This revision was automatically updated to reflect the committed changes.

Herald added a subscriber: imp. · View Herald TranscriptJul 15 2018, 5:10 PM

Revision Contents
Changeset List

Path

Size

sys/

kern/

36 lines

Diff 45217

sys/kern/kern_sig.c

Loading...