Page MenuHomeFreeBSD

devel/avarice: unbreak build under 11.2-RELEASE (and clang 6)
ClosedPublic

Authored by leres on Jul 8 2018, 8:57 PM.
Tags
None
Referenced Files
F161001707: D16184.diff
Mon, Jun 29, 6:14 PM
Unknown Object (File)
Sat, Jun 27, 12:26 PM
Unknown Object (File)
Wed, Jun 10, 9:31 AM
Unknown Object (File)
Tue, Jun 9, 9:50 PM
Unknown Object (File)
Apr 26 2026, 6:44 AM
Unknown Object (File)
Apr 23 2026, 11:22 PM
Unknown Object (File)
Apr 21 2026, 12:22 AM
Unknown Object (File)
Apr 10 2026, 4:41 PM
Subscribers

Details

Summary

Proposed commit message:

After upgrading to 11.2-RELEASE devel/avarice fails to
compile with:

jtagrw.cc:134:13: error: cannot initialize return object of type 'uchar *' (aka 'unsigned char *') with an rvalue of type 'bool'

            return false;
                   ^~~~~

examination of the code shows another case with a similar
check that returns NULL.

I also filed an upstream bug report:

https://sourceforge.net/p/avarice/bugs/24/

PR: 229376
Reviewed by: ? (mentor)
Approved by: joerg (maintainer), ? (mentor)
Differential Revision: ?

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 17916
Build 17673: arc lint + arc unit