Page MenuHomeFreeBSD

Support multiple OPAL consoles, and don't crash if uart is not stdout
ClosedPublic

Authored by jhibbits on Jun 29 2018, 7:15 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Aug 29, 3:21 PM
Unknown Object (File)
Mon, Aug 24, 7:54 AM
Unknown Object (File)
Mon, Aug 17, 4:35 AM
Unknown Object (File)
Sat, Aug 15, 6:49 PM
Unknown Object (File)
Wed, Aug 5, 6:09 AM
Unknown Object (File)
Wed, Aug 5, 5:37 AM
Unknown Object (File)
Tue, Aug 4, 7:32 AM
Unknown Object (File)
Aug 1 2026, 4:37 PM
Subscribers

Details

Summary

If the chosen console is not the OPAL uart, but OPAL uart devices exist, the console device doesn't attach properly, and faults in the interrupt handler, with a NULL pointer dereference. To fix this, and as a byproduct, also support multiple OPAL consoles, refactor to have the console getc callback use the appropriate softc instead of the global console_sc, which may be NULL in the case of a different device being the console.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 17733
Build 17533: arc lint + arc unit

Event Timeline

Assuming you have tested this and it works, looks great.

This revision is now accepted and ready to land.Jun 29 2018, 7:18 PM
This revision was automatically updated to reflect the committed changes.