Page MenuHomeFreeBSD

Support multiple OPAL consoles, and don't crash if uart is not stdout
ClosedPublic

Authored by jhibbits on Jun 29 2018, 7:15 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Apr 21, 7:04 AM
Unknown Object (File)
Wed, Apr 15, 11:01 AM
Unknown Object (File)
Sat, Apr 11, 12:17 PM
Unknown Object (File)
Tue, Apr 7, 9:57 PM
Unknown Object (File)
Tue, Apr 7, 3:07 AM
Unknown Object (File)
Mon, Apr 6, 9:38 AM
Unknown Object (File)
Mon, Apr 6, 5:34 AM
Unknown Object (File)
Mon, Apr 6, 4:55 AM
Subscribers

Details

Summary

If the chosen console is not the OPAL uart, but OPAL uart devices exist, the console device doesn't attach properly, and faults in the interrupt handler, with a NULL pointer dereference. To fix this, and as a byproduct, also support multiple OPAL consoles, refactor to have the console getc callback use the appropriate softc instead of the global console_sc, which may be NULL in the case of a different device being the console.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 17733
Build 17533: arc lint + arc unit

Event Timeline

Assuming you have tested this and it works, looks great.

This revision is now accepted and ready to land.Jun 29 2018, 7:18 PM
This revision was automatically updated to reflect the committed changes.