Page MenuHomeFreeBSD
Differential D15965

x11/polybar: Fix build against x11/xcb-proto 1.13.
ClosedPublic
Actions

Authored by rigoletto on Jun 22 2018, 1:48 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Nov 25, 3:59 AM
Unknown Object (File)
Sat, Nov 23, 5:23 PM
Unknown Object (File)
Fri, Nov 22, 10:46 AM
Unknown Object (File)
Fri, Nov 22, 6:49 AM
Unknown Object (File)
Wed, Nov 20, 1:11 PM
Unknown Object (File)
Sun, Nov 17, 9:34 AM
Unknown Object (File)
Sun, Nov 17, 3:51 AM
Unknown Object (File)
Sun, Nov 17, 12:41 AM
View All Files
Subscribers
bapt
mat

Details

Reviewers
tcberner
capt_redbeard_protonmail.com
Group Reviewers
portmgr
Commits
rP473406: x11/polybar: Fix build against x11/xcb-proto 1.13.
Summary

PR: 228330

  • bring to ~HEAD
  • add DEBUG OPTION

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

rigoletto created this revision.Jun 22 2018, 1:48 PM
Herald added a subscriber: mat. · View Herald TranscriptJun 22 2018, 1:48 PM
Harbormaster completed remote builds in B17541: Diff 44300.Jun 22 2018, 1:48 PM
rigoletto edited the summary of this revision. (Show Details)Jun 22 2018, 1:53 PM
rigoletto updated this revision to Diff 44303.Jun 22 2018, 2:52 PM

Use git tags on GH_TUPLE.

Harbormaster completed remote builds in B17542: Diff 44303.Jun 22 2018, 2:52 PM
rigoletto retitled this revision from x11/polybar: broken. to x11/polybar: Fix build against x11/xcb-proto 1.13..Jun 22 2018, 3:45 PM
rigoletto edited the summary of this revision. (Show Details)
rigoletto added reviewers: capt_redbeard_protonmail.com, portmgr.
rigoletto updated this revision to Diff 44308.Jun 22 2018, 3:49 PM

Had to bring localbase:ldflags back, something related with the i3 module needs some patches. I just fail to understand how it was building perfectly fine a few days ago.

Harbormaster completed remote builds in B17544: Diff 44308.Jun 22 2018, 3:49 PM
tcberner added inline comments.Jun 22 2018, 7:14 PM
x11/polybar/pkg-message
1 ↗(On Diff #44308)

^ I think there is not much gained by this change :D

rigoletto updated this revision to Diff 44322.Jun 22 2018, 8:46 PM
rigoletto added a subscriber: bapt.

That was my 'set textwidth=80' config in neovim. ^^

Also taking maintainer ship, if @bapt decide to take it later it is fine.

Thanks!

Harbormaster completed remote builds in B17552: Diff 44322.Jun 22 2018, 8:46 PM
rigoletto updated this revision to Diff 44351.Jun 23 2018, 4:30 PM

Just bringing to a commit ahead which fix a annoying thing.

Thanks.

Harbormaster completed remote builds in B17568: Diff 44351.Jun 23 2018, 4:30 PM
rigoletto updated this revision to Diff 44352.Jun 23 2018, 5:09 PM

Returning to the previous versioning scheme to avoid PORTEPOCH. The next version should not take too long to come out, however the port needs update because it is currently broken.

Thanks!

Harbormaster completed remote builds in B17569: Diff 44352.Jun 23 2018, 5:09 PM
rigoletto updated this revision to Diff 44353.Jun 23 2018, 5:41 PM

But now it needs GH_TAGNAME.

Harbormaster completed remote builds in B17570: Diff 44353.Jun 23 2018, 5:41 PM
tcberner added inline comments.Jun 23 2018, 6:24 PM
x11/polybar/Makefile
4 ↗(On Diff #44353)

^that looks like its going backwards now 23->22

4 ↗(On Diff #44353)

sorry, I was looking at the Diff-between-Diff view -- ignore me :D

rigoletto added a comment.Jun 23 2018, 6:56 PM

The github commit date for new commits are not really helpfull. The fisrt time I looked on there is '8 hours ago' and later '2 days ago'. :-/

rigoletto updated this revision to Diff 44479.Jun 26 2018, 6:40 PM
rigoletto marked 2 inline comments as done.

Bring back BROKEN_*.

Thanks!

Harbormaster completed remote builds in B17636: Diff 44479.Jun 26 2018, 6:40 PM
rigoletto updated this revision to Diff 44480.Jun 26 2018, 6:42 PM

Fix the day of the commit. Thanks! :)

Harbormaster completed remote builds in B17637: Diff 44480.Jun 26 2018, 6:42 PM
rigoletto updated this revision to Diff 44481.Jun 26 2018, 6:45 PM

Fix distfile.

Harbormaster completed remote builds in B17638: Diff 44481.Jun 26 2018, 6:45 PM
tcberner added a comment.Jun 26 2018, 6:45 PM

^ don't you need to regenerate the distinfo now?

This revision was not accepted when it landed; it landed in state Needs Review.Jun 26 2018, 7:08 PM
Closed by commit rP473406: x11/polybar: Fix build against x11/xcb-proto 1.13. (authored by tcberner). · Explain Why
This revision was automatically updated to reflect the committed changes.
mat added inline comments.Jun 27 2018, 11:11 AM
head/x11/polybar/Makefile
4

This is wrong.

$ git describe --tags 028b141
3.1.0-161-g028b141

and too late to make this one correctly. Please, read this before inventing another version:

https://www.freebsd.org/doc/en/books/porters-handbook/makefile-distfiles.html#makefile-master_sites-github-ex5

Revision Contents
Changeset List

Diff 44485

View Options

head/x11/polybar/Makefile

Loading...
View Options

head/x11/polybar/distinfo

Loading...
View Options

head/x11/polybar/files/patch-cmake_01-core.cmake

Loading...
View Options

head/x11/polybar/files/patch-cmake_03-libs.cmake

Loading...
View Options

head/x11/polybar/files/patch-include_adapters_alsa_generic.hpp

Loading...
View Options

head/x11/polybar/files/patch-man_CMakeLists.txt

Loading...
View Options

head/x11/polybar/pkg-plist

Loading...