science/paraview: Fix protobuf conflict, upgrade to 5.5.1, modernize options
ClosedPublic
Actions

Authored by jwb on Jun 26 2018, 7:05 PM.

Details

Reviewers

jrm
wen

Commits

rP473414: science/paraview: Fix protobuf conflict, upgrade to 5.5.1, modernize options

Summary

science/paraview: Fix protobuf conflict, upgrade to 5.5.1, modernize options
Approved by jrm (mentor) or wen (mentor)
Differential to be added to commit message

Test Plan

portlint -AC: looks fine
Tested port options
Passed poudriere on {10.4,11.1}-{amd64,i386}

Diff Detail

Repository

rP FreeBSD ports repository

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 17641
Build 17446: arc lint + arc unit

Event Timeline

jwb created this revision.Jun 26 2018, 7:05 PM

Herald added a subscriber: mat. · View Herald TranscriptJun 26 2018, 7:05 PM

Harbormaster completed remote builds in B17641: Diff 44484.Jun 26 2018, 7:05 PM

jrm added inline comments.Jun 26 2018, 10:34 PM

science/paraview/Makefile
69	Can this line be removed now?

Apparently so. Never would have thought of it. The handbook is vague about
this, but it seems to work fine. I ran a make clean rmconfig configure
with 3 different options combos and got expected results.

Harbormaster completed remote builds in B17646: Diff 44494.Jun 26 2018, 11:34 PM

I think you needed the .include before you switched to OPTION helpers.

This revision is now accepted and ready to land.Jun 26 2018, 11:43 PM

Yeah, I got that, but now I'm uncertain about exactly which OPTIONS features require it. The handbook isn't clear and the mk file is too big to study in detail. I'll just try without it and add when needed, I guess.

Closed by commit rP473414: science/paraview: Fix protobuf conflict, upgrade to 5.5.1, modernize options (authored by jwb). · Explain WhyJun 27 2018, 12:04 AM

This revision was automatically updated to reflect the committed changes.

In D16024#339403, @jwb wrote:

Yeah, I got that, but now I'm uncertain about exactly which OPTIONS features require it. The handbook isn't clear and the mk file is too big to study in detail. I'll just try without it and add when needed, I guess.

Regarding options, you only need to include bsd.port.options.mk when you need to use the PORT_OPTIONS variable.

Thanks!